[BUG] quads --ls-filter doesn't properly account for disks.count

[sadsfae]

I'd expect this query to only return Dell R640's with only a single disk, instead it returns all systems.

# quads --ls-hosts --filter "model==r640, disks.count==1" | wc -l
347

Same results with disks.count>=1

# quads --ls-hosts --filter "model==r640, disks.count<=1" | wc -l
347

[kambiz-aghaiepour]

I think the issue with the way the query is constructed is that it will match hosts that have only 1 disk of ANY type. For example:

# quads --host somehost.example.com --ls-disks
disk0:
  type: scsi
  size: 480
  count: 1
disk1:
  type: scsi
  size: 1920
  count: 2
disk2:
  type: nvme
  size: 1600
  count: 1

The above host has a total of 4 disks, but it only has a 1 count for the scsi/480 and the nvme/1600 disks. So it will match the search criteria.

[kambiz-aghaiepour]

More information on things that work and don't.

Works:

quads --ls-hosts --filter 'model==r640,disks.count>=1,disks.disk_type==nvme'

Works:

quads --ls-hosts --filter 'model==r640,disks.count>=1,disks.disk_type==nvme,retired==false'

Works:

quads --ls-hosts --filter 'broken==false,retired==false'`

Does NOT work:

quads --ls-hosts --filter 'model==r640,disks.count>=1,disks.disk_type==nvme,broken==false'

Does NOT work:

quads --ls-hosts --filter 'model==r640,disks.count>=1,disks.disk_type==nvme,broken==false,retired==false'

In other words, when you limit the return of --ls-hosts to include a filter, with specific characteristics such as disk characteristics, but also stipulate broken==false, it seems to trigger the error.