fix(proxies): save backend status code before update, use it for action filtering, update agent to always use status code from rule for action filtering

Author: joelwurtz

src/ngx_http_redirectionio_module.c

@@ -232,6 +232,7 @@ static ngx_int_t ngx_http_redirectionio_create_ctx_handler(ngx_http_request_t *r
         ctx->project_key.len = 0;
         ctx->scheme.len = 0;
         ctx->host.len = 0;
+        ctx->backend_response_status_code = 0;
 
         if (ngx_http_complex_value(r, conf->project_key, &ctx->project_key) != NGX_OK) {
             return NGX_DECLINED;
@@ -404,7 +405,7 @@ static ngx_int_t ngx_http_redirectionio_log_handler(ngx_http_request_t *r) {
         return NGX_DECLINED;
     }
 
-    should_log = redirectionio_action_should_log_request(ctx->action, conf->enable_logs != NGX_HTTP_REDIRECTIONIO_OFF, r->headers_out.status);
+    should_log = redirectionio_action_should_log_request(ctx->action, conf->enable_logs != NGX_HTTP_REDIRECTIONIO_OFF, ctx->backend_response_status_code);
 
     if (!should_log) {
         return NGX_DECLINED;

src/ngx_http_redirectionio_module.h

@@ -82,6 +82,7 @@ typedef struct {
     struct REDIRECTIONIO_Action                     *action;
     struct REDIRECTIONIO_HeaderMap                  *response_headers;
     struct REDIRECTIONIO_FilterBodyAction           *body_filter;
+    ngx_uint_t                                      backend_response_status_code;
 
     ngx_uint_t                                      connection_error;
     ngx_uint_t                                      wait_for_connection;

src/ngx_http_redirectionio_module_filter.c

@@ -32,7 +32,8 @@ ngx_int_t ngx_http_redirectionio_match_on_response_status_header_filter(ngx_http
     }
 
     // Copy string
-    redirect_status_code = redirectionio_action_get_status_code(ctx->action, r->headers_out.status);
+    ctx->backend_response_status_code = r->headers_out.status;
+    redirect_status_code = redirectionio_action_get_status_code(ctx->action, ctx->backend_response_status_code);
 
     if (redirect_status_code == 0) {
         return ngx_http_redirectionio_headers_filter(r);
@@ -100,8 +101,8 @@ ngx_int_t ngx_http_redirectionio_headers_filter(ngx_http_request_t *r) {
     // Copy specific headers
     ngx_http_redirectionio_header_content_type_read(r, &header_map);
 
-    ngx_log_debug1(NGX_LOG_DEBUG_HTTP, r->connection->log, 0, "http redirectionio filtering on response status code %d", r->headers_out.status);
-    header_map = (struct REDIRECTIONIO_HeaderMap *)redirectionio_action_header_filter_filter(ctx->action, header_map, r->headers_out.status, conf->show_rule_ids == NGX_HTTP_REDIRECTIONIO_ON);
+    ngx_log_debug1(NGX_LOG_DEBUG_HTTP, r->connection->log, 0, "http redirectionio filtering on response status code %d", ctx->backend_response_status_code);
+    header_map = (struct REDIRECTIONIO_HeaderMap *)redirectionio_action_header_filter_filter(ctx->action, header_map, ctx->backend_response_status_code, conf->show_rule_ids == NGX_HTTP_REDIRECTIONIO_ON);
 
     if (header_map == NULL) {
         ngx_log_debug0(NGX_LOG_DEBUG_HTTP, r->connection->log, 0, "http redirectionio no filter to add");
@@ -197,7 +198,7 @@ static ngx_int_t ngx_http_redirectionio_create_filter_body(ngx_http_request_t *r
     }
 
     // Create body filter
-    ctx->body_filter = (struct REDIRECTIONIO_FilterBodyAction *)redirectionio_action_body_filter_create(ctx->action, r->headers_out.status);
+    ctx->body_filter = (struct REDIRECTIONIO_FilterBodyAction *)redirectionio_action_body_filter_create(ctx->action, ctx->backend_response_status_code);
 
     if (ctx->body_filter != NULL) {
         // Remove content length header