perf: use case-insensitive comparison instead of normalization for command names (#410)

Author: supercaracal

lib/redis_client/cluster.rb

@@ -152,8 +152,9 @@ def router
     end
 
     def method_missing(name, *args, **kwargs, &block)
-      if router.command_exists?(name)
-        args.unshift(name)
+      cmd = name.respond_to?(:name) ? name.name : name.to_s
+      if router.command_exists?(cmd)
+        args.unshift(cmd)
         command = @command_builder.generate(args, kwargs)
         return router.send_command(:call_v, command, &block)
       end

lib/redis_client/cluster/command.rb

@@ -3,7 +3,6 @@
 require 'redis_client'
 require 'redis_client/cluster/errors'
 require 'redis_client/cluster/key_slot_converter'
-require 'redis_client/cluster/normalized_cmd_name'
 
 class RedisClient
   class Cluster
@@ -30,7 +29,7 @@ def load(nodes, slow_command_timeout: -1) # rubocop:disable Metrics/AbcSize
           nodes&.each do |node|
             regular_timeout = node.read_timeout
             node.read_timeout = slow_command_timeout > 0.0 ? slow_command_timeout : regular_timeout
-            reply = node.call('COMMAND')
+            reply = node.call('command')
             node.read_timeout = regular_timeout
             commands = parse_command_reply(reply)
             cmd = ::RedisClient::Cluster::Command.new(commands)
@@ -51,7 +50,7 @@ def parse_command_reply(rows)
           rows&.each_with_object({}) do |row, acc|
             next if row[0].nil?
 
-            acc[row[0].downcase] = ::RedisClient::Cluster::Command::Detail.new(
+            acc[row.first] = ::RedisClient::Cluster::Command::Detail.new(
               first_key_position: row[3],
               key_step: row[5],
               write?: row[2].include?('write'),
@@ -73,38 +72,59 @@ def extract_first_key(command)
       end
 
       def should_send_to_primary?(command)
-        name = ::RedisClient::Cluster::NormalizedCmdName.instance.get_by_command(command)
-        @commands[name]&.write?
+        find_command_info(command.first)&.write?
       end
 
       def should_send_to_replica?(command)
-        name = ::RedisClient::Cluster::NormalizedCmdName.instance.get_by_command(command)
-        @commands[name]&.readonly?
+        find_command_info(command.first)&.readonly?
       end
 
       def exists?(name)
-        @commands.key?(::RedisClient::Cluster::NormalizedCmdName.instance.get_by_name(name))
+        @commands.key?(name) || @commands.key?(name.to_s.downcase(:ascii))
       end
 
       private
 
-      def determine_first_key_position(command) # rubocop:disable Metrics/CyclomaticComplexity
-        case name = ::RedisClient::Cluster::NormalizedCmdName.instance.get_by_command(command)
-        when 'eval', 'evalsha', 'zinterstore', 'zunionstore' then 3
-        when 'object' then 2
-        when 'memory'
+      def find_command_info(name)
+        @commands[name] || @commands[name.to_s.downcase(:ascii)]
+      end
+
+      def determine_first_key_position(command) # rubocop:disable Metrics/CyclomaticComplexity, Metrics/AbcSize, Metrics/PerceivedComplexity
+        if command.first.casecmp('get').zero?
+          find_command_info(command.first)&.first_key_position.to_i
+        elsif command.first.casecmp('mget').zero?
+          find_command_info(command.first)&.first_key_position.to_i
+        elsif command.first.casecmp('set').zero?
+          find_command_info(command.first)&.first_key_position.to_i
+        elsif command.first.casecmp('mset').zero?
+          find_command_info(command.first)&.first_key_position.to_i
+        elsif command.first.casecmp('del').zero?
+          find_command_info(command.first)&.first_key_position.to_i
+        elsif command.first.casecmp('eval').zero?
+          3
+        elsif command.first.casecmp('evalsha').zero?
+          3
+        elsif command.first.casecmp('zinterstore').zero?
+          3
+        elsif command.first.casecmp('zunionstore').zero?
+          3
+        elsif command.first.casecmp('object').zero?
+          2
+        elsif command.first.casecmp('memory').zero?
           command[1].to_s.casecmp('usage').zero? ? 2 : 0
-        when 'migrate'
+        elsif command.first.casecmp('migrate').zero?
           command[3].empty? ? determine_optional_key_position(command, 'keys') : 3
-        when 'xread', 'xreadgroup'
+        elsif command.first.casecmp('xread').zero?
+          determine_optional_key_position(command, 'streams')
+        elsif command.first.casecmp('xreadgroup').zero?
           determine_optional_key_position(command, 'streams')
         else
-          @commands[name]&.first_key_position.to_i
+          find_command_info(command.first)&.first_key_position.to_i
         end
       end
 
       def determine_optional_key_position(command, option_name)
-        idx = command.map { |e| e.to_s.downcase }.index(option_name&.downcase)
+        idx = command.map { |e| e.to_s.downcase(:ascii) }.index(option_name)
         idx.nil? ? 0 : idx + 1
       end
     end

lib/redis_client/cluster/node.rb

@@ -90,7 +90,7 @@ def initialize(scale_read: false, **kwargs)
 
         def build_connection_prelude
           prelude = super.dup
-          prelude << ['READONLY'] if @scale_read
+          prelude << ['readonly'] if @scale_read
           prelude.freeze
         end
       end
@@ -309,7 +309,7 @@ def refetch_node_info_list(startup_clients) # rubocop:disable Metrics/AbcSize, M
           work_group.push(i, raw_client) do |client|
             regular_timeout = client.read_timeout
             client.read_timeout = @config.slow_command_timeout > 0.0 ? @config.slow_command_timeout : regular_timeout
-            reply = client.call_once('CLUSTER', 'NODES')
+            reply = client.call_once('cluster', 'nodes')
             client.read_timeout = regular_timeout
             parse_cluster_node_reply(reply)
           rescue StandardError => e

lib/redis_client/cluster/node/latency_replica.rb

@@ -47,7 +47,7 @@ def measure_latencies(clients, concurrent_worker) # rubocop:disable Metrics/AbcS
               min = DUMMY_LATENCY_MSEC
               MEASURE_ATTEMPT_COUNT.times do
                 starting = obtain_current_time
-                cli.call_once('PING')
+                cli.call_once('ping')
                 duration = obtain_current_time - starting
                 min = duration if duration < min
               end

lib/redis_client/cluster/normalized_cmd_name.rb

@@ -18,15 +18,15 @@ def watch(keys) # rubocop:disable Metrics/AbcSize
         handle_redirection(slot, retry_count: 1) do |nd|
           nd.with do |c|
             c.ensure_connected_cluster_scoped(retryable: false) do
-              c.call('ASKING') if @asking
-              c.call('WATCH', *keys)
+              c.call('asking') if @asking
+              c.call('watch', *keys)
               begin
                 yield(c, slot, @asking)
               rescue ::RedisClient::ConnectionError
                 # No need to unwatch on a connection error.
                 raise
               rescue StandardError
-                c.call('UNWATCH')
+                c.call('unwatch')
                 raise
               end
             rescue ::RedisClient::CommandError => e

lib/redis_client/cluster/optimistic_locking.rb

@@ -290,7 +290,7 @@ def redirect_command(node, pipeline, inner_index)
       end
 
       def try_asking(node)
-        node.call('ASKING') == 'OK'
+        node.call('asking') == 'OK'
       rescue StandardError
         false
       end

lib/redis_client/cluster/pipeline.rb

@@ -2,7 +2,6 @@
 
 require 'redis_client'
 require 'redis_client/cluster/errors'
-require 'redis_client/cluster/normalized_cmd_name'
 
 class RedisClient
   class Cluster
@@ -108,12 +107,21 @@ def next_event(timeout = nil) # rubocop:disable Metrics/AbcSize, Metrics/Cycloma
 
       private
 
-      def _call(command)
-        case ::RedisClient::Cluster::NormalizedCmdName.instance.get_by_command(command)
-        when 'subscribe', 'psubscribe', 'ssubscribe' then call_to_single_state(command)
-        when 'unsubscribe', 'punsubscribe' then call_to_all_states(command)
-        when 'sunsubscribe' then call_for_sharded_states(command)
-        else call_to_single_state(command)
+      def _call(command) # rubocop:disable Metrics/AbcSize
+        if command.first.casecmp('subscribe').zero?
+          call_to_single_state(command)
+        elsif command.first.casecmp('psubscribe').zero?
+          call_to_single_state(command)
+        elsif command.first.casecmp('ssubscribe').zero?
+          call_to_single_state(command)
+        elsif command.first.casecmp('unsubscribe').zero?
+          call_to_all_states(command)
+        elsif command.first.casecmp('punsubscribe').zero?
+          call_to_all_states(command)
+        elsif command.first.casecmp('sunsubscribe').zero?
+          call_for_sharded_states(command)
+        else
+          call_to_single_state(command)
         end
       end