Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ZREVRANK: Added the optional WITHSCORE argument. #2528

Closed
Tracked by #2523
chayim opened this issue Apr 2, 2023 · 5 comments · Fixed by #2531
Closed
Tracked by #2523

Support ZREVRANK: Added the optional WITHSCORE argument. #2528

chayim opened this issue Apr 2, 2023 · 5 comments · Fixed by #2531

Comments

@chayim
Copy link
Contributor

chayim commented Apr 2, 2023

Documented here.

@SoulPancake
Copy link
Contributor

I'd like to work on this @chayim

@SoulPancake
Copy link
Contributor

In the documentation for this and ZRANK both ( #2527 ) the examples for the withscore arg shows an error,
is that supposed to be updated? Should we raise it somewhere else?

@SoulPancake
Copy link
Contributor

I found it raised redis/redis-doc#2354
here
Trying to find clarity on the response and then would write tests for the new cmd with optional arg.

@SoulPancake
Copy link
Contributor

@monkey92t For this and #2527
Should we introduce a new command with the withScore param
Or should we replace the existing one with something like

type ZRankCmd struct {
	baseCmd

	member   string
	withScore bool
	val      []interface{}
}

And then handle it accordingly?

@SoulPancake
Copy link
Contributor

My vote would be to add a separate ZRankWithScore Command
What are your thoughts? @monkey92t @chayim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants