Skip to content

HIncrBy missing from HashCmdable #3343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AvyChanna opened this issue Apr 15, 2025 · 2 comments
Closed

HIncrBy missing from HashCmdable #3343

AvyChanna opened this issue Apr 15, 2025 · 2 comments

Comments

@AvyChanna
Copy link

#3305 adds HIncrByFloat but removes the normal HIncrBy, that used int64. This breaks older clients that use UniversalClients.

I don't think this was intentional, since the function still exists. Just the interface is not exposing it anymore.

Expected Behavior

HashCmdable should have HIncrBy like so -

type HashCmdable interface {
	...
	HIncrBy(ctx context.Context, key, field string, incr int64) *IntCmd
	HIncrByFloat(ctx context.Context, key, field string, incr float64) *FloatCmd
	...
}
@ndyakov
Copy link
Member

ndyakov commented Apr 15, 2025

@AvyChanna Thank you for reporting! Looking into this.

@ndyakov
Copy link
Member

ndyakov commented Apr 15, 2025

Fixed by #3344

@ndyakov ndyakov closed this as completed Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants