Ensure connectAdvanced only re-renders if derived props change

markerikson · markerikson · commit 8d0cb87dfd91 · 2018-11-11T16:38:10.000-05:00
diff --git a/src/components/connectAdvanced.js b/src/components/connectAdvanced.js
@@ -203,11 +203,7 @@ export default function connectAdvanced(
           store
         )
 
-        if (pure) {
-          return this.selectChildElement(derivedProps, forwardedRef)
-        }
-
-        return <FinalWrappedComponent {...derivedProps} ref={forwardedRef} />
+        return this.selectChildElement(derivedProps, forwardedRef)
       }
 
       render() {

Original file line number	Diff line number	Diff line change
`@@ -203,11 +203,7 @@ export default function connectAdvanced(`
`203`	`203`	`store`
`204`	`204`	`)`
`205`	`205`
`206`		`- if (pure) {`
`207`		`- return this.selectChildElement(derivedProps, forwardedRef)`
`208`		`- }`
`209`		`-`
`210`		`- return <FinalWrappedComponent {...derivedProps} ref={forwardedRef} />`
	`206`	`+ return this.selectChildElement(derivedProps, forwardedRef)`
`211`	`207`	`}`
`212`	`208`
`213`	`209`	`render() {`