Skip to content

Commit 7b3f7e2

Browse files
committed
Remove ES5 builds and target modern browsers
1 parent d2d0f70 commit 7b3f7e2

File tree

6 files changed

+24
-28
lines changed

6 files changed

+24
-28
lines changed

packages/toolkit/.size-limit.js

+12-12
Original file line numberDiff line numberDiff line change
@@ -19,30 +19,30 @@ function withRtkPath(suffix) {
1919
join(__dirname)
2020
),
2121
new webpack.NormalModuleReplacementPlugin(
22-
/rtk-query-react.esm.js/,
22+
/rtk-query-react.modern.js/,
2323
(r) => {
2424
const old = r.request
2525
r.request = r.request.replace(
26-
/rtk-query-react.esm.js$/,
26+
/rtk-query-react.modern.js$/,
2727
`rtk-query-react.${suffix}`
2828
)
2929
// console.log(old, '=>', r.request)
3030
}
3131
),
32-
new webpack.NormalModuleReplacementPlugin(/rtk-query.esm.js/, (r) => {
32+
new webpack.NormalModuleReplacementPlugin(/rtk-query.modern.js/, (r) => {
3333
const old = r.request
3434
r.request = r.request.replace(
35-
/rtk-query.esm.js$/,
35+
/rtk-query.modern.js$/,
3636
`rtk-query.${suffix}`
3737
)
3838
// console.log(old, '=>', r.request)
3939
}),
4040
new webpack.NormalModuleReplacementPlugin(
41-
/redux-toolkit.esm.js$/,
41+
/redux-toolkit.modern.js$/,
4242
(r) => {
4343
const old = r.request
4444
r.request = r.request.replace(
45-
/redux-toolkit.esm.js$/,
45+
/redux-toolkit.modern.js$/,
4646
`redux-toolkit.${suffix}`
4747
)
4848
// console.log(old, '=>', r.request)
@@ -69,29 +69,29 @@ const ignoreAll = [
6969
module.exports = [
7070
{
7171
name: `1. entry point: @reduxjs/toolkit`,
72-
path: 'dist/redux-toolkit.esm.js',
72+
path: 'dist/redux-toolkit.modern.js',
7373
},
7474
{
7575
name: `1. entry point: @reduxjs/toolkit/query`,
76-
path: 'dist/query/rtk-query.esm.js',
76+
path: 'dist/query/rtk-query.modern.js',
7777
},
7878
{
7979
name: `1. entry point: @reduxjs/toolkit/query/react`,
80-
path: 'dist/query/react/rtk-query-react.esm.js',
80+
path: 'dist/query/react/rtk-query-react.modern.js',
8181
},
8282
{
8383
name: `2. entry point: @reduxjs/toolkit (without dependencies)`,
84-
path: 'dist/redux-toolkit.esm.js',
84+
path: 'dist/redux-toolkit.modern.js',
8585
ignore: ignoreAll,
8686
},
8787
{
8888
name: `2. entry point: @reduxjs/toolkit/query (without dependencies)`,
89-
path: 'dist/query/rtk-query.esm.js',
89+
path: 'dist/query/rtk-query.modern.js',
9090
ignore: ignoreAll,
9191
},
9292
{
9393
name: `2. entry point: @reduxjs/toolkit/query/react (without dependencies)`,
94-
path: 'dist/query/react/rtk-query-react.esm.js',
94+
path: 'dist/query/react/rtk-query-react.modern.js',
9595
ignore: ignoreAll,
9696
},
9797
]

packages/toolkit/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
"access": "public"
2424
},
2525
"main": "dist/index.js",
26-
"module": "dist/redux-toolkit.esm.js",
26+
"module": "dist/redux-toolkit.modern.js",
2727
"unpkg": "dist/redux-toolkit.umd.min.js",
2828
"types": "dist/index.d.ts",
2929
"devDependencies": {

packages/toolkit/query/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"version": "1.0.0",
44
"description": "",
55
"main": "../dist/query/index.js",
6-
"module": "../dist/query/rtk-query.esm.js",
6+
"module": "../dist/query/rtk-query.modern.js",
77
"unpkg": "../dist/query/rtk-query.umd.min.js",
88
"types": "../dist/query/index.d.ts",
99
"author": "Mark Erikson <[email protected]>",

packages/toolkit/query/react/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"version": "1.0.0",
44
"description": "",
55
"main": "../../dist/query/react/index.js",
6-
"module": "../../dist/query/react/rtk-query-react.esm.js",
6+
"module": "../../dist/query/react/rtk-query-react.modern.js",
77
"unpkg": "../../dist/query/react/rtk-query-react.umd.min.js",
88
"author": "Mark Erikson <[email protected]>",
99
"license": "MIT",

packages/toolkit/scripts/build.ts

+8-12
Original file line numberDiff line numberDiff line change
@@ -36,56 +36,52 @@ const buildTargets: BuildOptions[] = [
3636
{
3737
format: 'cjs',
3838
name: 'cjs.development',
39+
target: 'es2018',
3940
minify: false,
4041
env: 'development',
4142
},
42-
4343
{
4444
format: 'cjs',
4545
name: 'cjs.production.min',
46+
target: 'es2018',
4647
minify: true,
4748
env: 'production',
4849
},
49-
// ESM, embedded `process`, ES5 syntax: typical Webpack dev
50-
{
51-
format: 'esm',
52-
name: 'esm',
53-
minify: false,
54-
env: '',
55-
},
5650
// ESM, embedded `process`, ES2017 syntax: modern Webpack dev
5751
{
5852
format: 'esm',
5953
name: 'modern',
60-
target: 'es2017',
54+
target: 'es2018',
6155
minify: false,
6256
env: '',
6357
},
6458
// ESM, pre-compiled "dev", ES2017 syntax: browser development
6559
{
6660
format: 'esm',
6761
name: 'modern.development',
68-
target: 'es2017',
62+
target: 'es2018',
6963
minify: false,
7064
env: 'development',
7165
},
7266
// ESM, pre-compiled "prod", ES2017 syntax: browser prod
7367
{
7468
format: 'esm',
7569
name: 'modern.production.min',
76-
target: 'es2017',
70+
target: 'es2018',
7771
minify: true,
7872
env: 'production',
7973
},
8074
{
8175
format: 'umd',
8276
name: 'umd',
77+
target: 'es2018',
8378
minify: false,
8479
env: 'development',
8580
},
8681
{
8782
format: 'umd',
8883
name: 'umd.min',
84+
target: 'es2018',
8985
minify: true,
9086
env: 'production',
9187
},
@@ -197,7 +193,7 @@ async function bundle(options: BuildOptions & EntryPointOptions) {
197193
const esVersion =
198194
target in esVersionMappings
199195
? esVersionMappings[target]
200-
: ts.ScriptTarget.ES5
196+
: ts.ScriptTarget.ES2017
201197

202198
const origin = chunk.text
203199
const sourcemap = extractInlineSourcemap(origin)

packages/toolkit/scripts/types.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ export interface BuildOptions {
1111
| 'umd.min'
1212
minify: boolean
1313
env: 'development' | 'production' | ''
14-
target?: 'es2017'
14+
target?: 'es2017' | 'es2018' | 'es2019' | 'es2020'
1515
}
1616

1717
export interface EntryPointOptions {

0 commit comments

Comments
 (0)