Skip to content
This repository was archived by the owner on Sep 27, 2023. It is now read-only.

Typescript 4.5 type generation is broken #513

Closed
VictorGlindasPaf opened this issue Nov 18, 2021 · 6 comments · Fixed by #519
Closed

Typescript 4.5 type generation is broken #513

VictorGlindasPaf opened this issue Nov 18, 2021 · 6 comments · Fixed by #519
Labels

Comments

@VictorGlindasPaf
Copy link

VictorGlindasPaf commented Nov 18, 2021

After updating toTypescript 4.5, I'm getting broken types output from the relay compiler.
I'm on version 14.3.0 of relay-compiler-language-typescript.

// Typescript 4.4
import { FragmentRefs } from "relay-runtime";
// Typescript 4.5
import { FragmentRefs as } from "relay-runtime";
@VictorGlindasPaf VictorGlindasPaf changed the title Typescript 4.5 issue Typescript 4.5 type generation is broken Nov 18, 2021
@piotrblasiak
Copy link

piotrblasiak commented Nov 18, 2021

Same here

@saihaj
Copy link
Member

saihaj commented Nov 18, 2021

Yeah CI is breaking here for the upgrade #512 @

@tszarzynski
Copy link

We started observing similar issue using TS 4.3.5 and v.14.3.0.

It currently works fine with

"relay-compiler-language-typescript": "^14.0.0",
"typescript": "~4.4.4",

@Strandedpirate
Copy link

Same error here too. In my case I had to nuke my yarn.lock and re-install and then this error started occurring. The yarn.lock file got totally re-written, so I just undid the changes, did another yarn install and it stopped generating the bad graphql files.

@VictorGlindasPaf
Copy link
Author

VictorGlindasPaf commented Nov 22, 2021

Same error here too. In my case I had to nuke my yarn.lock and re-install and then this error started occurring. The yarn.lock file got totally re-written, so I just undid the changes, did another yarn install and it stopped generating the bad graphql files.

If you revert the yarn.lock file and install, that will install the old version. So it's no wonder that it stopped generating the bad files since you didn't actually update anything.

@github-actions
Copy link

🚀 Issue was released in v15.0.0 🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants