Skip to content

Commit 8ff4d5f

Browse files
authored
internally deprecate createappfixture (#12458)
1 parent 5813c1e commit 8ff4d5f

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

integration/helpers/create-fixture.ts

+7
Original file line numberDiff line numberDiff line change
@@ -192,6 +192,13 @@ export async function createFixture(init: FixtureInit, mode?: ServerMode) {
192192
};
193193
}
194194

195+
/**
196+
* @deprecated Use `integration/helpers/vite.ts`'s `test` instead
197+
*
198+
* This implementation sometimes runs a request handler in memory, forcing tests to manually manage stdout/stderr
199+
* which has caused many integration tests to leak noisy logs for expected errors.
200+
* It also means that sometimes the CLI is skipped over in those tests, missing out on code paths that should be tested.
201+
*/
195202
export async function createAppFixture(fixture: Fixture, mode?: ServerMode) {
196203
let startAppServer = async (): Promise<{
197204
port: number;

0 commit comments

Comments
 (0)