False-positive "Server-only module referenced by client"

[punkpeye]

[commonjs--resolver] Server-only module referenced by client

    '/Users/frank/Developer/punkpeye/glama/app/services/slonik.server.ts' imported by route 'app/routes/_authenticated/_app/onboarding/synchronised-chats/_route.tsx'

  React Router automatically removes server-code from these exports:
    `loader`, `action`, `unstable_middleware`, `headers`

  But other route exports in 'app/routes/_authenticated/_app/onboarding/synchronised-chats/_route.tsx' depend on '/Users/frank/Developer/punkpeye/glama/app/services/slonik.server.ts'.

  See https://remix.run/docs/en/main/guides/vite#splitting-up-client-and-server-code

and here is the entire _route.tsx

import { defineAuthenticatedLoader } from '#app/remix/defineAuthenticatedLoader.ts';
import { redirect } from '#app/remix/redirect.ts';
import { setupChatPlayground } from '#app/routines/chat/setupChatPlayground.ts';
import { transact } from '#app/services/slonik.server.ts';
import { getPath } from '#app/utilities/getPath.ts';

export const loader = defineAuthenticatedLoader(
  async ({ authenticatedVisitorSession }) => {
    const chatPlayground = await transact({
      name: 'start onboarding',
      transaction: async (transaction) => {
        return await setupChatPlayground({
          authenticatedVisitorSession,
          sessions: [
            { hostedLlmModelNid: 'openai/gpt-4o' },
            { hostedLlmModelNid: 'anthropic/claude-3-5-sonnet' },
            { hostedLlmModelNid: 'deepseek/deepseek-chat-v3' },
          ],
          transaction,
        });
      },
    });

    return redirect(
      getPath('/playground/:uid', {
        uid: chatPlayground.uid,
      }),
    );
  },
);

@brophdawg11 There needs to be some sort of an escape hatch for these situations.

[punkpeye]

Looks like, oddly enough, this was caused by lingering dead imports?

This fixed it:

[patch.diff](https://gist.github.com/punkpeye/02129bfbedef832e22aa070c5db4025d#file-patch-diff)
diff --git a/app/routes/_authenticated/_app/settings/workspace/subscription/_index/_route.tsx b/app/routes/_authenticated/_app/settings/workspace/subscription/_index/_route.tsx
index d8921e39..0fd71a47 100644
--- a/app/routes/_authenticated/_app/settings/workspace/subscription/_index/_route.tsx
+++ b/app/routes/_authenticated/_app/settings/workspace/subscription/_index/_route.tsx
@@ -1,6 +1,5 @@
 import { createMeta } from '#app/factories/createMeta.ts';
 import { defineAuthenticatedLoader } from '#app/remix/defineAuthenticatedLoader.server.ts';
-import { redirect } from '#app/remix/redirect.server.ts';
 import { pool, sql } from '#app/services/slonik.server.ts';
 import { css } from '#app/styled-system/css/index.js';
 import { dayjs } from '#app/utilities/date.ts';
diff --git a/app/routes/_authentication/sign-out/_route.tsx b/app/routes/_authentication/sign-out/_route.tsx
index dd6c8fa0..32dbd86c 100644
--- a/app/routes/_authentication/sign-out/_route.tsx
+++ b/app/routes/_authentication/sign-out/_route.tsx
@@ -1,7 +1,6 @@
 import { useAutoSubmitForm } from '#app/hooks/useAutoSubmitForm.ts';
 import { defineAction } from '#app/remix/defineAction.server.ts';
-import { redirect } from '#app/remix/redirect.ts';
-import { redirectDocument } from '#app/remix/redirectDocument.ts';
+import { redirectDocument } from '#app/remix/redirectDocument.server.ts';
 import { ProgressIndicator } from '#app/routes/_authenticated/_app/playground/~uid/ProgressIndicator.tsx';
 import {
   addToast,

[GabenGar]

"Lingering dead imports" still can have side-effects depending on server symbols. Especially since server code naturally tends to be a non-analyzable hodgepodge of function calls at the top module level.
Not exactly a false-positive, but the react-router erring on safe side and assuming the import in which none of the symbols are used is a side-effect import.