partial-app-loading example throws in updateMatchComponents when clicking around

[sophiebits]

We don't find the refs where we expect them due to the way that the PreInbox and PreDashboard components work (PreInbox's owner is Dashboard instead of PreDashboard, the handler specified by the route).

[ryanflorence]

:(

That's new. Do you know if its because of the react upgrade or a change in our code?

[sophiebits]

Guessing it was introduced in the change to make activeRoute a function (73570ed).

[zgotsch]

Seems to have been introduced in 0177cdd, which is where the updateMatchComponents logic is introduced.

[ryanflorence]

    function updateMatchComponents(matches, refs) {
      var i = 0, component;
      while (component = refs[REF_NAME]) {
        matches[i++].component = component;
        refs = component.refs;
      }
    }

The while loop runs one more time then there are matches.

[eldh]

Any progress on this or pointers on how to fix/get around it?

[eldh]

A fix that seems to work for me, probably there are nicer, better, cleaner ways to get around it:

while ((component = refs[REF_NAME]) && (matches[i+1] !== undefined)) {
    matches[i++].component = component;
    refs = component.refs;
  }

[ryanflorence]

^ @mjackson any issues with this code you can think of?

[mjackson]

I haven't had time to track down this bug yet, but there's obviously something wrong with matches in that loop. Anyone care to make a unit test?

[alexkirsz]

This happens when a handler component creates its own __activeRoute__ ref, usually when passing down its unaltered props to a child component.

[kyle-beattie]

Any more progress or ways to solve this?

[ryanflorence]

as soon as we finish server-side rendering this is number one priority before v1 release.

[ryanflorence]

(but no, we haven't worked on it)

[mjackson]

I'm not 100% sure (because the partial-app-loading example is currently broken) but this commit may have helped resolve this bug.

[ryanflorence]

we'll need a webpack build for it

[mjackson]

If you wanna use webpack, I'm down. My only issues with webpack are that the docs are a wall of text which makes it difficult for me to understand how to use it. But if we're going to use it on one example, let's just use it for everything. I don't like the idea of building some stuff with Browserify and other stuff with webpack. We should always work with Browserify tho.

[gaearon]

Would've been nice if there was no build step for examples. Just launching webpack-dev-server and that's it. Webpack can sometimes be not documented very well, but @sokra is extremely helpful and quick to respond to issues so I don't think it's a problem.

[mjackson]

@gaearon agree. no build step would be really nice.

[ryanflorence]

I want webpack back now that partial app loading is fixed :)

[gaearon]

BTW I have an exception in that loop, wonder why:

Uncaught TypeError: Cannot read property 'refs' of undefined

in refs = match.component.refs;

(But that's with my own partial loading, which worked in 0.9.3 but broke in master)

[sophiebits]

I have an okay understanding of webpack configuration and can probably help if you have questions.

[ryanflorence]

I'll switch it back to webpack, we still need browserify for the global build (unless webpack can do this too?)

[ryanflorence]

@gaearon it is done :)

scripts/dev-examples

Then just open http://localhost:8080.