href() builder produces invalid URL on optional segments

[cloudkite]

I'm using React Router as a...

Framework

Reproduction

Given that i have a route in routes.ts as :

    route(
      "task/:taskId/v?/:versionId?",
      "task.route.tsx",
    ),

System Info

react-router v7.2

Used Package Manager

npm

Expected Behavior

href("task/:taskId/v?/:versionId?", { taskId: "123" }) === "task/123"
href("task/:taskId/v?/:versionId?", { taskId: "123", versionId: "hello" }) === "task/123/v/hello"

Actual Behavior

href("task/:taskId/v?/:versionId?", { taskId: "123" }) === "task/123/v?"
href("task/:taskId/v?/:versionId?", { taskId: "123", versionId: "hello" }) === "task/123/v?/hello"

[martinliptak]

Also came across this problem - seems like a bug.

[pcattori]

Fixed by #13595 , which should be available next release

[github-actions]

🤖 Hello there,

We just published version 7.6.1 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!