Skip to content

Default <Redirect path> to * #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mjackson opened this issue Aug 28, 2014 · 3 comments
Closed

Default <Redirect path> to * #242

mjackson opened this issue Aug 28, 2014 · 3 comments

Comments

@mjackson
Copy link
Member

It kind of feels like <Redirect path> should default to *.

<Route handler={App}>
  <Route name="home" handler={Home}/>
  <Route name="about" handler={About}/>

  <!-- Catch anything else and redirect home -->
  <Redirect to="home"/>
</Route>

Since <Redirect> respects the order of routes, I think it reads quite nicely.

@ryanflorence
Copy link
Member

<NotFoundRedirect/>?

@mjackson
Copy link
Member Author

The <NotFoundRoute> does not respect the ordering of routes, but <Redirect> does. I think <NotFoundRedirect> might confuse people.

@ryanflorence
Copy link
Member

🎯

@lock lock bot locked as resolved and limited conversation to collaborators Jan 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants