Skip to content

Too long item test name causes RP server errors #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
frizzby opened this issue Jun 20, 2017 · 3 comments
Closed

Too long item test name causes RP server errors #9

frizzby opened this issue Jun 20, 2017 · 3 comments

Comments

@frizzby
Copy link
Collaborator

frizzby commented Jun 20, 2017

RP server limits length of name field of a test to be 256 chars max.
But this agent may produce name value much longer than 256 chars. This leads to server error:

ResponseError: 4001: Incorrect Request. {} [[Field 'name' should have size from '1' to '256'.] ]

This is how generated test name looks like:
${options} = BuiltIn.Catenate (--variablefile ${VF1}, -V ${VF2}:arg, -V "${VF2}:arg2:value;with;semi;colons", -V "${VF2};semicolon;separator", -V "${VF2};semi:colon;separator:with:colons", --VariableFile ${VF2}, -V ${VF2}:FAIL, -V ${VF2}:too:many:args, --variablef ${VF3} --VARIABLEFILE ${VF4} --VariableFile pythonpath_varfile.py --VariableFile pythonpath_varfile.py:1:2:3 --pythonpath ${VARFILEDIR}/pythonpath_dir

How to reproduce:

  1. clone robotframework source
  2. execute robotframework's acceptance tests as follows:
    ./atest/run.py python --listener robotframework_reportportal.listener --variable RP_UUID:"uuid" --variable RP_ENDPOINT:"https://endpoint" --variable RP_LAUNCH:”ROBOT” --variable RP_PROJECT:"you_name_personal" atest/robot/variables/
@frizzby
Copy link
Collaborator Author

frizzby commented Jun 20, 2017

@krasoffski @DzmitryHumianiuk Do you think it is safe and acceptable solution to trim name length to 256 chars max by agent before posting to RP? What is expected behavior here? If my understanding is correct this was a design decision to cap name's length — it is supposed to be concise.

@DzmitryHumianiuk
Copy link
Member

@frizzby @krasoffski yes. we limited it to have starting point in limits.
but dictated more of common sense, than because of nice design on UI.

@avarabyeu please correct me, don't we have any other reasons to have limit as 256 for testItem name?

@frizzby
Copy link
Collaborator Author

frizzby commented Jun 24, 2017

OK, until we have a better solution i'm going to trim name field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants