Skip to content

Commit 5bbaf62

Browse files
authored
Merge pull request #25 from request/safe-buffer
Migrating to safe-buffer for security reasons.
2 parents e72d830 + cdc47b9 commit 5bbaf62

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

index.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ var net = require('net')
77
, events = require('events')
88
, assert = require('assert')
99
, util = require('util')
10+
, Buffer = require('safe-buffer').Buffer
1011
;
1112

1213
exports.httpOverHttp = httpOverHttp
@@ -118,7 +119,7 @@ TunnelingAgent.prototype.createSocket = function createSocket(options, cb) {
118119
var placeholder = {}
119120
self.sockets.push(placeholder)
120121

121-
var connectOptions = mergeOptions({}, self.proxyOptions,
122+
var connectOptions = mergeOptions({}, self.proxyOptions,
122123
{ method: 'CONNECT'
123124
, path: options.host + ':' + options.port
124125
, agent: false
@@ -183,7 +184,7 @@ TunnelingAgent.prototype.createSocket = function createSocket(options, cb) {
183184
TunnelingAgent.prototype.removeSocket = function removeSocket(socket) {
184185
var pos = this.sockets.indexOf(socket)
185186
if (pos === -1) return
186-
187+
187188
this.sockets.splice(pos, 1)
188189

189190
var pending = this.requests.shift()
@@ -198,7 +199,7 @@ function createSecureSocket(options, cb) {
198199
var self = this
199200
TunnelingAgent.prototype.createSocket.call(self, options, function(socket) {
200201
// 0 is dummy port for v0.6
201-
var secureSocket = tls.connect(0, mergeOptions({}, self.options,
202+
var secureSocket = tls.connect(0, mergeOptions({}, self.options,
202203
{ servername: options.host
203204
, socket: socket
204205
}

package.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,9 @@
1111
"files": [
1212
"index.js"
1313
],
14-
"dependencies": {},
14+
"dependencies": {
15+
"safe-buffer": "^5.0.1"
16+
},
1517
"devDependencies": {},
1618
"optionalDependencies": {},
1719
"engines": {

0 commit comments

Comments
 (0)