Array docstrings (#78)

* start working on Array docstrings

* docs for indexOf and includes

* remove Array.fromIterator + friends in favor of specialized functions in Iterator

* more array docstrings

* changelog

* remove unsafe Array.from functions

* more array docstrings

* Apply suggestions from code review

Co-authored-by: Glenn Slotte <[email protected]>

* add back accidentally removed fns

* fixes after PR review

* more tweaks after PR comments

---------

Co-authored-by: Glenn Slotte <[email protected]>

Author: zth

CHANGELOG.md

@@ -25,6 +25,8 @@
 - Add `panic`/`Error.panic`. https://github.com/rescript-association/rescript-core/pull/72
 - The globally available `null` value now originates from `Nullable` and not `Null`, just like the globally available `undefined` value does. https://github.com/rescript-association/rescript-core/pull/88
 - Add `Int.range` and `Int.rangeWithOptions`, https://github.com/rescript-association/rescript-core/pull/52
+- Remove `Array.fromIterator` and `Array.fromIteratorWithMap`. The same functions exist in `Iterator` as `Iterator.fromArray` and `Iterator.fromArrayWithMapper`. https://github.com/rescript-association/rescript-core/pull/78
+- Remove unsafe `Array.from` and `Array.fromWithMap`. https://github.com/rescript-association/rescript-core/pull/78
 
 ### Documentation
 

src/Core__Array.res

@@ -3,16 +3,10 @@
 external getUnsafe: (array<'a>, int) => 'a = "%array_unsafe_get"
 external setUnsafe: (array<'a>, int, 'a) => unit = "%array_unsafe_set"
 
-@val external from: 'a => array<'b> = "Array.from"
-@val external fromWithMap: ('a, 'b => 'c) => array<'c> = "Array.from"
-
 @val external fromArrayLike: Js.Array2.array_like<'a> => array<'a> = "Array.from"
 @val
 external fromArrayLikeWithMap: (Js.Array2.array_like<'a>, 'a => 'b) => array<'b> = "Array.from"
 
-@val external fromIterator: Core__Iterator.t<'a> => array<'a> = "Array.from"
-@val external fromIteratorWithMap: (Core__Iterator.t<'a>, 'a => 'b) => array<'b> = "Array.from"
-
 @send external fillAllInPlace: (array<'a>, 'a) => unit = "fill"
 
 @send external fillInPlaceToEnd: (array<'a>, 'a, ~start: int) => unit = "fill"