You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Many JavaScript APIs have methods with trailing optional args and are currently bound in Core as multiple different functions for different argument counts.
However, since ReScript 11, we can have trailing optional args in functions/bindings without needing a () at the end anymore. This allows us to create more idiomatic bindings for such cases, corresponding more closely to the original JS API.
I have already created the following PRs for a some such cases:
There are quite a few other bindings left that should be changed in a similar way (e.g., Date.make).
For some such functions, the trailing undefineds emitted by the 11.0 compiler for the omitted arguments will be problematic and therefore ReScript 11.1 will be required.
The text was updated successfully, but these errors were encountered:
@cknitt do you see any other APIs than Date.makeWith* for this issue?
The thing is we could not use optional parameters for this given this could create invalid dates (it would only work if missing parameters would be replaced with null instead of undefined).
There's one thing we could fix though, they use a ~date parameter instead of ~day, would you like me to correct this?
Many JavaScript APIs have methods with trailing optional args and are currently bound in Core as multiple different functions for different argument counts.
However, since ReScript 11, we can have trailing optional args in functions/bindings without needing a
()
at the end anymore. This allows us to create more idiomatic bindings for such cases, corresponding more closely to the original JS API.I have already created the following PRs for a some such cases:
There are quite a few other bindings left that should be changed in a similar way (e.g.,
Date.make
).For some such functions, the trailing
undefined
s emitted by the 11.0 compiler for the omitted arguments will be problematic and therefore ReScript 11.1 will be required.The text was updated successfully, but these errors were encountered: