You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
- For the native analysis binary tests: `cd analysis && make test`.
79
+
- For the native analysis binary tests: `make test`.
80
80
81
81
## Change the Grammar
82
82
@@ -105,7 +105,7 @@ We call a few binaries and it's tricky to call them properly cross-platform. Her
105
105
106
106
## General Coding Guidance
107
107
108
-
-`server/` is a standalone folder that can be vendored by e.g. Vim and Sublime Text. Keep it light, don't add deps unless absolutely necessarily, and don't accidentally use a runtime dep from the top level `package.json`.
108
+
-`server/` is a standalone LSP server. Keep it light, don't add deps unless absolutely necessarily, and don't accidentally use a runtime dep from the top level `package.json`.
109
109
- This codebase stayed alive by not trying to babysit long-living processes. Be fast, call a binary and shut down.
110
110
111
111
## Rough Description Of How The Plugin Works
@@ -206,9 +206,8 @@ We're happy to gather more resources over time here, including more in-depth get
206
206
_This below will automatically release the LSP package as well._
207
207
208
208
1. Bump the version to an _even minor_ version number in `package.json` and `server/package.json` and their lockfiles. It's very important that it's an even minor like `1.8.0`, and not `1.7.0`. This is because even minors are reserved for actual releases, and uneven minors for pre-releases. Commit and push the version bump.
209
-
2. Make sure @ryyppy is aware of your changes. He needs to sync them over to the vim plugin.
210
-
3. Let CI build your version bump commit.
211
-
4. Tag the commit with the version number (e.g. `git tag 1.6.0`) and push the tag (e.g. `git push origin 1.6.0`). Another build will trigger, which should automatically:
209
+
2. Let CI build your version bump commit.
210
+
3. Tag the commit with the version number (e.g. `git tag 1.6.0`) and push the tag (e.g. `git push origin 1.6.0`). Another build will trigger, which should automatically:
212
211
- create a `rescript-vscode-<version-number>.vsix` file
213
212
- publish that extension version to the VSCode marketplace
0 commit comments