Skip to content

Commit ad547b4

Browse files
committed
more updates
1 parent 05b8740 commit ad547b4

File tree

3 files changed

+9
-5
lines changed

3 files changed

+9
-5
lines changed

Diff for: .vscodeignore

+1
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ server/node_modules/.bin
99
node_modules/.bin
1010
analysis/
1111
tools/
12+
scripts/
1213
dune-project
1314
analysis.opam
1415
tools.opam

Diff for: CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,10 @@
1212
1313
## master
1414

15+
#### :house: Internal
16+
17+
- Move `rescript-tools` to OCaml code and make `analysis` an library. https://github.com/rescript-lang/rescript-vscode/pull/855
18+
1519
## 1.30.0
1620

1721
#### :rocket: New Feature

Diff for: CONTRIBUTING.md

+4-5
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ opam install ocaml-lsp-server
7676

7777
<img width="359" alt="image" src="https://user-images.githubusercontent.com/1909539/97448639-19db0800-18ee-11eb-875a-d17cd1b141d1.png">
7878

79-
- For the native analysis binary tests: `cd analysis && make test`.
79+
- For the native analysis binary tests: `make test`.
8080

8181
## Change the Grammar
8282

@@ -105,7 +105,7 @@ We call a few binaries and it's tricky to call them properly cross-platform. Her
105105

106106
## General Coding Guidance
107107

108-
- `server/` is a standalone folder that can be vendored by e.g. Vim and Sublime Text. Keep it light, don't add deps unless absolutely necessarily, and don't accidentally use a runtime dep from the top level `package.json`.
108+
- `server/` is a standalone LSP server. Keep it light, don't add deps unless absolutely necessarily, and don't accidentally use a runtime dep from the top level `package.json`.
109109
- This codebase stayed alive by not trying to babysit long-living processes. Be fast, call a binary and shut down.
110110

111111
## Rough Description Of How The Plugin Works
@@ -206,9 +206,8 @@ We're happy to gather more resources over time here, including more in-depth get
206206
_This below will automatically release the LSP package as well._
207207

208208
1. Bump the version to an _even minor_ version number in `package.json` and `server/package.json` and their lockfiles. It's very important that it's an even minor like `1.8.0`, and not `1.7.0`. This is because even minors are reserved for actual releases, and uneven minors for pre-releases. Commit and push the version bump.
209-
2. Make sure @ryyppy is aware of your changes. He needs to sync them over to the vim plugin.
210-
3. Let CI build your version bump commit.
211-
4. Tag the commit with the version number (e.g. `git tag 1.6.0`) and push the tag (e.g. `git push origin 1.6.0`). Another build will trigger, which should automatically:
209+
2. Let CI build your version bump commit.
210+
3. Tag the commit with the version number (e.g. `git tag 1.6.0`) and push the tag (e.g. `git push origin 1.6.0`). Another build will trigger, which should automatically:
212211
- create a `rescript-vscode-<version-number>.vsix` file
213212
- publish that extension version to the VSCode marketplace
214213
- create an automatic release on GitHub

0 commit comments

Comments
 (0)