Skip to content

Js.String2.match_ not returning option<array<Js.String2.t>> #5643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
harry-xm opened this issue Sep 7, 2022 · 3 comments
Closed

Js.String2.match_ not returning option<array<Js.String2.t>> #5643

harry-xm opened this issue Sep 7, 2022 · 3 comments

Comments

@harry-xm
Copy link

harry-xm commented Sep 7, 2022

In [email protected], function signature of Js.String2.match_ is (Js.String2.t, Js.Re.t) => option<array<Js.String2.t>>.

In [email protected], the function signature has one more nested option<> as follows.

(
  Js.String2.t,
  Js.Re.t,
) => option<array<option<Js.String2.t>>>

Is this breaking change intentional?

How to reproduce

  1. In VSCode, hover over a Js.String2.match_ function call.
@harry-xm harry-xm changed the title Js.String2.match_ not returning option<arrayJs.String2.t>> Js.String2.match_ not returning option<array<Js.String2.t>> Sep 7, 2022
@Minnozz
Copy link
Contributor

Minnozz commented Sep 7, 2022

See #5070
It is mentioned in the changelog under breaking changes: https://github.com/rescript-lang/rescript-compiler/blob/master/CHANGELOG.md#1000

@harry-xm
Copy link
Author

harry-xm commented Sep 8, 2022

Thanks. https://rescript-lang.org/docs/manual/latest/api/js/string-2#match is not updated yet, should I open an issue for that?

@cristianoc
Copy link
Collaborator

Thanks. https://rescript-lang.org/docs/manual/latest/api/js/string-2#match is not updated yet, should I open an issue for that?

Good catch yes please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants