JSX4: loc missing in error for not existing prop

[cknitt]

In certain cases, when referencing a prop that does not exist, the loc information seems to get lost.

E.g. for

module A = {
  @react.component
  let make = () => React.null
}

@react.component
let make = () => <A someProp={<div />} />

the error message does not show in which line the error occurred:

  This record expression is expected to have type A.props
  The field someProp does not belong to type A.props

and the error is shown in VS Code like this:

Compare with this case which works fine:

module A = {
  @react.component
  let make = () => React.null
}

@react.component
let make = () => <A someProp="test" />

It gives

  6 │ @react.component
  7 │ let make = () => <A someProp="test" />
  8 │

  This record expression is expected to have type A.props
  The field someProp does not belong to type A.props

[mununki]

I couldn't reproduce the error msg without loc for the example with master, 10.1_release, or the latest pre-release compiler.


Can you confirm what version of the compiler shows the error without loc?

[cknitt]

@mununki Sorry for not specifying this in detail. I am using 10.1.1 with JSX4 automatic mode.

It seems the problem occurs in automatic mode only. You can also check this here (upcoming 10.1.2 playground, not sure how long the link will work): https://rescript-lang-7alwuc0qv-rescript-association.vercel.app/try?version=v10.1.2&code=ALBWGcA8GEHsDsBmBLA5gCgN4AIBuBTAJ3GQQC5sAWAGmwFtYATfCgIgEMBXAF1jve7IAxq2wBfAJQAoKQ0acANvmwBBbAF5smKdmzBC+dkO4A6IXwAOCfPG47sS7vXYBrZZvQSNAPmwAlQ2MTeEUFKTEZfUDTczoreBs7R2c3DWxPH2wAHjVwPnwABUJYC3VMLMZkXGwAem8xWu8pIA

[mununki]

The simple example would be:

@@jsxConfig({version:4, mode: "automatic"})
let _ = <A someProp={<b />} />

I found that the loc of `someProp" is missing in three cases:

• classic, Uppercase someProp={<B />}
• automatic, Uppercase someProp={<B />}
• automatic, lowercase someProp={<b />}

Only classic, lowercase someProp={<b />} keeps the loc.

I'll look into it.

[mununki]

@cknitt Can you try to test with #5960?

[cknitt]

@mununki Just tested it and it looks good with #5960. Thanks a lot for your work!