Skip to content

Bug: rescript format -all with uncurried false breaks uncurried functions ([email protected]) #6369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DZakh opened this issue Aug 28, 2023 · 9 comments

Comments

@DZakh
Copy link
Member

DZakh commented Aug 28, 2023

image image

It's not critical in this place, but I don't think that formatter should cause changes in the generated code.

@DZakh
Copy link
Member Author

DZakh commented Aug 28, 2023

It might be a problem for cases like this.

image

I'll rewrite it to use @scope instead, but still.

@zth
Copy link
Collaborator

zth commented Aug 28, 2023

Can you check if rc2 fixes it? I committed a potential fix for this that hasn't been released yet: https://github.com/rescript-lang/rescript-compiler/blob/master/CHANGELOG.md#bug-bug-fix

@DZakh
Copy link
Member Author

DZakh commented Aug 28, 2023

Yes, it works there. @zth @cknitt I'd really appreciate a release. I've started migrating FE at work to ReScript@11, and this actually happened to be blocking.
Also, here's a fix for failing tests in master #6370

@cknitt
Copy link
Member

cknitt commented Aug 28, 2023

@DZakh
Copy link
Member Author

DZakh commented Aug 28, 2023

Thanks

@DZakh DZakh closed this as completed Aug 28, 2023
@DZakh
Copy link
Member Author

DZakh commented Aug 30, 2023

Sorry. I've tested it incorrectly. The issue still exists.

@DZakh DZakh reopened this Aug 30, 2023
@zth
Copy link
Collaborator

zth commented Aug 30, 2023

Can you create a reproduction?

@DZakh
Copy link
Member Author

DZakh commented Aug 30, 2023

Yep #6378

@DZakh
Copy link
Member Author

DZakh commented Aug 30, 2023

I've added a fix in the PR #6378 after @cristianoc's pointing.

@DZakh DZakh closed this as completed Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants