Skip to content

GenType: Issue typing JSON.t and Dict.t from RescriptCore #6563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
reck753 opened this issue Jan 12, 2024 · 2 comments
Closed

GenType: Issue typing JSON.t and Dict.t from RescriptCore #6563

reck753 opened this issue Jan 12, 2024 · 2 comments
Labels
stale Old issues that went stale

Comments

@reck753
Copy link

reck753 commented Jan 12, 2024

I encountered this issue while trying to migrate from 10.1.4 to 11.0.0.
These are the possible imports depending on how the module was used (more in reproduction repo):

import type {t as Core__JSON_t} from '@rescript/core/src/Core__JSON.gen';
import type {t as JSON_t} from './JSON.gen';

See the reproduction repo here.

Edit:
Do I need to create a shim for them?
Based on this PR and this forum post, I thought it might not be needed, at least for Dict.t. I also, tried creating one for the JSON, but it didn't work.

@reck753
Copy link
Author

reck753 commented Jan 12, 2024

Found this comment from :

While they're not as high pri as "Gentype is broken on Core", sill good to document them.

Does it mean they are not supported?

Copy link

github-actions bot commented Jan 7, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Old issues that went stale label Jan 7, 2025
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Old issues that went stale
Projects
None yet
Development

No branches or pull requests

1 participant