Skip to content

Parentheses incorrectly removed by printer, leading to wrong application of @uncurry #6784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
cknitt opened this issue May 26, 2024 · 2 comments
Open

Parentheses incorrectly removed by printer, leading to wrong application of @uncurry #6784

cknitt opened this issue May 26, 2024 · 2 comments
Assignees
@shulhi
Labels
bug syntax
Milestone
v12

Comments

@cknitt
Copy link
Member

cknitt commented May 26, 2024

Example from rescript-webapi:

@val external queueMicrotask: (@uncurry (unit => unit)) => unit = "queueMicrotask"

is reformatted to

@val external queueMicrotask: (@uncurry unit => unit) => unit = "queueMicrotask"

which applies @uncurry incorrectly (giving an "unused attribute" warning in v12/master after I fixed the unused attribute checks in #6643).
@cknitt cknitt added the bug label May 26, 2024
@cknitt
Copy link
Member Author

cknitt commented May 27, 2024

(in uncurried mode only)

@shulhi
Copy link
Member

shulhi commented Aug 16, 2024

This is similar to #6638

@cknitt cknitt added this to the v12 milestone Aug 25, 2024
@cknitt cknitt added the syntax label Aug 25, 2024
@shulhi shulhi self-assigned this Sep 1, 2024
@shulhi shulhi mentioned this issue Sep 2, 2024
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shulhi shulhi

Labels
bug syntax
Projects
None yet
Milestone
v12
Development

No branches or pull requests
2 participants
@cknitt @shulhi