Skip to content

refactor: split dir for CLI and dev scripts #6782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/get_artifact_dir_name.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
const fs = require("fs");
const os = require("os");

const artifactDirName = require("../../scripts/bin_path").dirName;
const { dirName: artifactDirName } = require("../../cli/bin_path.js");

// Pass artifactDirName to subsequent GitHub actions
fs.appendFileSync(
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/prepare_package_upload.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
const fs = require("fs");
const os = require("os");

const packageSpec = JSON.parse(fs.readFileSync("./package.json", "utf8"));
const packageSpec = require("rescript/package.json");
const { version } = packageSpec;

const commitHash = process.argv[2] || process.env.GITHUB_SHA;
Expand Down
2 changes: 1 addition & 1 deletion bsc
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"use strict";

var child_process = require("child_process");
var bsc_exe = require("./scripts/bin_path").bsc_exe;
var { bsc_exe } = require("./cli/bin_path");

var delegate_args = process.argv.slice(2);

Expand Down
File renamed without changes.
File renamed without changes.
2 changes: 1 addition & 1 deletion scripts/rescript_bsb.js → cli/rescript_bsb.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ const fs = require("fs");
const path = require("path");
var os = require("os");
const child_process = require("child_process");
const rescript_exe = require("./bin_path").rescript_exe;
const { rescript_exe } = require("./bin_path");

const cwd = process.cwd();
const lockFileName = path.join(cwd, ".bsb.lock");
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@
const child_process = require("child_process");
const fs = require("fs");

const bsc_exe = require("./bin_path").bsc_exe;
const ninja_exe = require("./bin_path").ninja_exe;
const { bsc_exe, ninja_exe } = require("./bin_path");

function checkNinja() {
if (!fs.existsSync(ninja_exe)) {
Expand Down
2 changes: 1 addition & 1 deletion scripts/rewatch → cli/rewatch
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
const path = require("path");
const child_process = require("child_process");

const binAbsolutePath = require("./bin_path").absolutePath;
const { absolutePath: binAbsolutePath } = require("./bin_path");
const rewatchExe = path.join(binAbsolutePath, "rewatch.exe");

const args = process.argv.slice(2);
Expand Down
2 changes: 1 addition & 1 deletion jscomp/build_tests/build_warn_as_error/input.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
var p = require("child_process");
var assert = require("assert");
var rescript_exe = require("../../../scripts/bin_path").rescript_exe;
var { rescript_exe } = require("#cli/bin_path");

var o = p.spawnSync(rescript_exe, ["build", "-warn-error", "+110"], {
encoding: "utf8",
Expand Down
2 changes: 1 addition & 1 deletion jscomp/build_tests/case/input.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
var p = require("child_process");
var assert = require("assert");
var rescript_exe = require("../../../scripts/bin_path").rescript_exe;
var { rescript_exe } = require("#cli/bin_path");
var o = p.spawnSync(rescript_exe, { encoding: "utf8", cwd: __dirname });

if (
Expand Down
2 changes: 1 addition & 1 deletion jscomp/build_tests/case2/input.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
var p = require("child_process");
var assert = require("assert");
var rescript_exe = require("../../../scripts/bin_path").rescript_exe;
var { rescript_exe } = require("#cli/bin_path");
var o = p.spawnSync(rescript_exe, { encoding: "utf8", cwd: __dirname });

if (
Expand Down
2 changes: 1 addition & 1 deletion jscomp/build_tests/case3/input.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ var p = require("child_process");
var fs = require("fs");
var path = require("path");
var assert = require("assert");
var rescript_exe = require("../../../scripts/bin_path").rescript_exe;
var { rescript_exe } = require("#cli/bin_path");
p.spawnSync(`${rescript_exe} clean && ${rescript_exe} build`, {
encoding: "utf8",
cwd: __dirname,
Expand Down
6 changes: 3 additions & 3 deletions jscomp/build_tests/cmd/input.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@ var p = require("child_process");

var assert = require("assert");

var bsc_exe_path = require("../../../scripts/bin_path").bsc_exe;
var { bsc_exe: bsc_exe_path } = require("#cli/bin_path");

var react = `
type u
type u

external a : u = "react" [@@module]

Expand All @@ -23,7 +23,7 @@ external foo : bla = "foo.react" [@@module]

external bar : unit -> bla = "bar" [@@val] [@@module "foo.react"]

let c = foo
let c = foo

let d = bar ()
`;
Expand Down
2 changes: 1 addition & 1 deletion jscomp/build_tests/custom_namespace/input.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
var child_process = require("child_process");
var assert = require("assert");
var rescript_exe = require("../../../scripts/bin_path").rescript_exe;
var { rescript_exe } = require("#cli/bin_path");

child_process.execSync(`${rescript_exe} clean && ${rescript_exe} build`, {
cwd: __dirname,
Expand Down
2 changes: 1 addition & 1 deletion jscomp/build_tests/cycle/input.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ const cp = require("child_process");
const assert = require("assert");
const fs = require("fs");
const path = require("path");
var rescript_exe = require("../../../scripts/bin_path").rescript_exe;
var { rescript_exe } = require("#cli/bin_path");

var output = cp.spawnSync(rescript_exe, { encoding: "utf8", shell: true });

Expand Down
2 changes: 1 addition & 1 deletion jscomp/build_tests/cycle1/input.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ const cp = require("child_process");
const assert = require("assert");
const fs = require("fs");
const path = require("path");
var rescript_exe = require("../../../scripts/bin_path").rescript_exe;
const { rescript_exe } = require("#cli/bin_path");

cp.execSync(`${rescript_exe} clean`, { cwd: __dirname });

Expand Down
2 changes: 1 addition & 1 deletion jscomp/build_tests/deprecated-package-specs/input.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
const child_process = require("child_process");
const assert = require("assert");
const rescript_exe = require("../../../scripts/bin_path").rescript_exe;
const { rescript_exe } = require("#cli/bin_path");

const out = child_process.spawnSync(rescript_exe, { encoding: "utf8" });
assert.match(
Expand Down
2 changes: 1 addition & 1 deletion jscomp/build_tests/devonly/input.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//@ts-check
var cp = require("child_process");
var rescript_exe = require("../../../scripts/bin_path").rescript_exe;
var { rescript_exe } = require("#cli/bin_path");

cp.execSync(rescript_exe, { cwd: __dirname, encoding: "utf8" });
2 changes: 1 addition & 1 deletion jscomp/build_tests/duplicated_symlinked_packages/input.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
const fs = require("fs");
const path = require("path");
const child_process = require("child_process");
const rescript_exe = require("../../../scripts/bin_path").rescript_exe;
const { rescript_exe } = require("#cli/bin_path");

const expectedFilePath = path.join(__dirname, "out.expected");

Expand Down
2 changes: 1 addition & 1 deletion jscomp/build_tests/exports/input.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
var child_process = require("child_process");
var rescript_exe = require("../../../scripts/bin_path").rescript_exe;
var { rescript_exe } = require("#cli/bin_path");

child_process.execSync(rescript_exe, {
cwd: __dirname,
Expand Down
2 changes: 1 addition & 1 deletion jscomp/build_tests/hyphen2/input.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
var p = require("child_process");
var rescript_exe = require("../../../scripts/bin_path").rescript_exe;
var { rescript_exe } = require("#cli/bin_path");

p.execSync(rescript_exe, { cwd: __dirname });
2 changes: 1 addition & 1 deletion jscomp/build_tests/in_source/input.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ var child_process = require("child_process");

var assert = require("assert");

var rescript_exe = require("../../../scripts/bin_path").rescript_exe;
var { rescript_exe } = require("#cli/bin_path");

assert.throws(
() => {
Expand Down
2 changes: 1 addition & 1 deletion jscomp/build_tests/install/input.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ var p = require("child_process");
var fs = require("fs");
var path = require("path");
var assert = require("assert");
var rescript_exe = require("../../../scripts/bin_path").rescript_exe;
var { rescript_exe } = require("#cli/bin_path");

p.spawnSync(rescript_exe, [`clean`], {
encoding: "utf8",
Expand Down
2 changes: 1 addition & 1 deletion jscomp/build_tests/nested/input.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ var p = require("child_process");
var assert = require("assert");
var fs = require("fs");
var path = require("path");
var rescript_exe = require("../../../scripts/bin_path").rescript_exe;
var { rescript_exe } = require("#cli/bin_path");
p.execSync(rescript_exe, { cwd: __dirname });

var content = fs.readFileSync(path.join(__dirname, "src", "demo.js"), "utf8");
Expand Down
2 changes: 1 addition & 1 deletion jscomp/build_tests/nnest/input.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ var p = require("child_process");
var assert = require("assert");
var fs = require("fs");
var path = require("path");
var rescript_exe = require("../../../scripts/bin_path").rescript_exe;
var { rescript_exe } = require("#cli/bin_path");
p.execSync(rescript_exe, { cwd: __dirname });

var content = fs.readFileSync(path.join(__dirname, "src", "demo.js"), "utf8");
Expand Down
2 changes: 1 addition & 1 deletion jscomp/build_tests/ns/input.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
var child_process = require("child_process");
var rescript_exe = require("../../../scripts/bin_path").rescript_exe;
var { rescript_exe } = require("#cli/bin_path");

child_process.execSync(rescript_exe, { cwd: __dirname });
2 changes: 1 addition & 1 deletion jscomp/build_tests/post-build/input.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
var child_process = require("child_process");
var assert = require("assert");
var rescript_exe = require("../../../scripts/bin_path").rescript_exe;
var { rescript_exe } = require("#cli/bin_path");

var out = child_process.spawnSync(rescript_exe, { encoding: "utf8" });

Expand Down
2 changes: 1 addition & 1 deletion jscomp/build_tests/react_ppx/input.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//@ts-check
var cp = require("child_process");
var rescript_exe = require("../../../scripts/bin_path").rescript_exe;
var { rescript_exe } = require("#cli/bin_path");

cp.execSync(rescript_exe, { cwd: __dirname });
2 changes: 1 addition & 1 deletion jscomp/build_tests/rerror/input.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
var child_process = require("child_process");
var assert = require("assert");
var rescript_exe = require("../../../scripts/bin_path").rescript_exe;
var { rescript_exe } = require("#cli/bin_path");
child_process.spawnSync(`${rescript_exe} clean`, {
cwd: __dirname,
encoding: "utf8",
Expand Down
2 changes: 1 addition & 1 deletion jscomp/build_tests/scoped_ppx/input.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
var cp = require("child_process");
var assert = require("assert");
var rescript_exe = require("../../../scripts/bin_path").rescript_exe;
var { rescript_exe } = require("#cli/bin_path");
cp.execSync(rescript_exe, { cwd: __dirname, encoding: "utf8" });

var output = cp.execSync(`${rescript_exe} build -- -t commands src/hello.ast`, {
Expand Down
2 changes: 1 addition & 1 deletion jscomp/build_tests/super_errors/input.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ const fs = require("fs");
const path = require("path");
const child_process = require("child_process");

var bsc = require("../../../scripts/bin_path").bsc_exe;
const { bsc_exe: bsc } = require("#cli/bin_path");

const expectedDir = path.join(__dirname, "expected");

Expand Down
2 changes: 1 addition & 1 deletion jscomp/build_tests/transitive_pinned_dependency1/input.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
var child_process = require("child_process");
var assert = require("assert");
var fs = require("fs");
var rescript_exe = require("../../../scripts/bin_path").rescript_exe;
var { rescript_exe } = require("#cli/bin_path");

console.log(
child_process.execSync(rescript_exe, { encoding: "utf8", cwd: "./a" })
Expand Down
8 changes: 0 additions & 8 deletions jscomp/build_tests/transitive_pinned_dependency1/package.json

This file was deleted.

2 changes: 1 addition & 1 deletion jscomp/build_tests/transitive_pinned_dependency2/input.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
var child_process = require("child_process");
var assert = require("assert");
var fs = require("fs");
var rescript_exe = require("../../../scripts/bin_path").rescript_exe;
var { rescript_exe } = require("#cli/bin_path");

console.log(
child_process.execSync(rescript_exe, { encoding: "utf8", cwd: "./a" })
Expand Down
8 changes: 0 additions & 8 deletions jscomp/build_tests/transitive_pinned_dependency2/package.json

This file was deleted.

2 changes: 1 addition & 1 deletion jscomp/build_tests/unboxed_bool_with_const/input.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

var cp = require("child_process");
var assert = require("assert");
var rescript_exe = require("../../../scripts/bin_path").rescript_exe;
var { rescript_exe } = require("#cli/bin_path");

var out = cp.spawnSync(rescript_exe, {
cwd: __dirname,
Expand Down
2 changes: 1 addition & 1 deletion jscomp/build_tests/uncurried-always/input.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
//@ts-check
const cp = require("child_process");
var rescript_exe = require("../../../scripts/bin_path").rescript_exe;
var { rescript_exe } = require("#cli/bin_path");

cp.execSync(`${rescript_exe} clean`, { cwd: __dirname });
cp.execSync(`${rescript_exe}`, { cwd: __dirname });
2 changes: 1 addition & 1 deletion jscomp/build_tests/unicode/input.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
//@ts-check
var child_process = require("child_process");
var rescript_exe = require("../../../scripts/bin_path").rescript_exe;
var { rescript_exe } = require("#cli/bin_path");

console.log(child_process.execSync(rescript_exe, { encoding: "utf8" }));

Expand Down
2 changes: 1 addition & 1 deletion jscomp/build_tests/warn_legacy_config/input.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
const { spawnSync } = require("child_process");
const assert = require("assert");
const rescript_exe = require("../../../scripts/bin_path").rescript_exe;
const { rescript_exe } = require("#cli/bin_path");

const output = spawnSync(rescript_exe, { encoding: "utf8" });
assert(
Expand Down
2 changes: 1 addition & 1 deletion jscomp/build_tests/weird_deps/input.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

var cp = require("child_process");
var assert = require("assert");
var rescript_exe = require("../../../scripts/bin_path").rescript_exe;
var { rescript_exe } = require("#cli/bin_path");

var out = cp.spawnSync(rescript_exe, {
cwd: __dirname,
Expand Down
2 changes: 1 addition & 1 deletion jscomp/build_tests/weird_devdeps/input.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

var cp = require("child_process");
var assert = require("assert");
var rescript_exe = require("../../../scripts/bin_path").rescript_exe;
var rescript_exe = require("#cli/bin_path").rescript_exe;

var out = cp.spawnSync(rescript_exe, {
cwd: __dirname,
Expand Down
2 changes: 1 addition & 1 deletion jscomp/build_tests/weird_names/input.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
var cp = require("child_process");
var assert = require("assert");
var path = require("path");
var rescript_exe = require("../../../scripts/bin_path").rescript_exe;
var { rescript_exe } = require("#cli/bin_path");

var out = cp.spawnSync(rescript_exe, { encoding: "utf8" });

Expand Down
2 changes: 1 addition & 1 deletion jscomp/build_tests/weird_names_not_found_bug/input.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
var cp = require("child_process");
var assert = require("assert");
var rescript_exe = require("../../../scripts/bin_path").rescript_exe;
var { rescript_exe } = require("#cli/bin_path");

var out = cp.spawnSync(rescript_exe, { encoding: "utf8" });
if (out.stderr !== "") {
Expand Down
2 changes: 1 addition & 1 deletion jscomp/build_tests/x-y/input.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
var p = require("child_process");
var rescript_exe = require("../../../scripts/bin_path").rescript_exe;
var { rescript_exe } = require("#cli/bin_path");

p.execSync(rescript_exe);
2 changes: 1 addition & 1 deletion jscomp/build_tests/xpkg/input.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
var p = require("child_process");
var assert = require("assert");
var rescript_exe = require("../../../scripts/bin_path").rescript_exe;
var { rescript_exe } = require("#cli/bin_path");
try {
var output = p.spawnSync(`${rescript_exe} build -regen`, {
shell: true,
Expand Down
2 changes: 1 addition & 1 deletion jscomp/build_tests/zerocycle/input.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
var p = require("child_process");
var assert = require("assert");
var rescript_exe = require("../../../scripts/bin_path").rescript_exe;
var { rescript_exe } = require("#cli/bin_path");
var out = p.spawnSync(rescript_exe, { encoding: "utf8", cwd: __dirname });
assert(out.status == 0);
2 changes: 1 addition & 1 deletion jscomp/others/release.ninja
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ rule cc
description = $in -> $out
rule cc_cmi
command = $bsc -bs-read-cmi -bs-cmi -bs-cmj $bsc_flags -I others $in
description = $in -> $out
description = $in -> $out

o others/belt.cmj others/belt.cmi : cc others/belt.res | $bsc
bsc_flags = $bsc_primitive_flags
Expand Down
2 changes: 1 addition & 1 deletion jscomp/runtime/release.ninja
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ rule cc
description = $in -> $out
rule cc_cmi
command = $bsc -bs-read-cmi -bs-cmi -bs-cmj $bsc_flags -I runtime $in
description = $in -> $out
description = $in -> $out

o runtime/bs_stdlib_mini.cmi : cc runtime/bs_stdlib_mini.resi
bsc_flags = -nopervasives
Expand Down
Loading