Add the missing loc of jsx call expression (#730)

Author: mununki

CHANGELOG.md

@@ -56,6 +56,7 @@
 - Fix parsing of spread props as an expression in JSX V4 https://github.com/rescript-lang/syntax/pull/721
 - Fix dropping attributes from props in make function in JSX V4 https://github.com/rescript-lang/syntax/pull/723
 - Fix an issue where error messages related to duplicate props were displayed without a loc and were unclear https://github.com/rescript-lang/syntax/pull/728
+- Fix issue where error messages related to non-existent props were displayed without location information https://github.com/rescript-lang/syntax/pull/730
 
 #### :eyeglasses: Spec Compliance
 

cli/reactjs_jsx_v4.ml

@@ -437,24 +437,25 @@ let transformUppercaseCall3 ~config modulePath mapper jsxExprLoc callExprLoc
         ( Exp.ident {loc = Location.none; txt = Ldot (Lident "React", "jsxs")},
           [] )
     in
-    Exp.apply ~attrs jsxExpr ([(nolabel, makeID); (nolabel, props)] @ keyAndUnit)
+    Exp.apply ~loc:jsxExprLoc ~attrs jsxExpr
+      ([(nolabel, makeID); (nolabel, props)] @ keyAndUnit)
   | _ -> (
     match (!childrenArg, keyProp) with
     | None, key :: _ ->
-      Exp.apply ~attrs
+      Exp.apply ~loc:jsxExprLoc ~attrs
         (Exp.ident
            {
              loc = Location.none;
              txt = Ldot (Lident "JsxPPXReactSupport", "createElementWithKey");
            })
         [key; (nolabel, makeID); (nolabel, props)]
     | None, [] ->
-      Exp.apply ~attrs
+      Exp.apply ~loc:jsxExprLoc ~attrs
         (Exp.ident
            {loc = Location.none; txt = Ldot (Lident "React", "createElement")})
         [(nolabel, makeID); (nolabel, props)]
     | Some children, key :: _ ->
-      Exp.apply ~attrs
+      Exp.apply ~loc:jsxExprLoc ~attrs
         (Exp.ident
            {
              loc = Location.none;
@@ -463,7 +464,7 @@ let transformUppercaseCall3 ~config modulePath mapper jsxExprLoc callExprLoc
            })
         [key; (nolabel, makeID); (nolabel, props); (nolabel, children)]
     | Some children, [] ->
-      Exp.apply ~attrs
+      Exp.apply ~loc:jsxExprLoc ~attrs
         (Exp.ident
            {
              loc = Location.none;
@@ -544,7 +545,7 @@ let transformLowercaseCall3 ~config mapper jsxExprLoc callExprLoc attrs
         ( Exp.ident {loc = Location.none; txt = Ldot (Lident "ReactDOM", "jsxs")},
           [] )
     in
-    Exp.apply ~attrs jsxExpr
+    Exp.apply ~loc:jsxExprLoc ~attrs jsxExpr
       ([(nolabel, componentNameExpr); (nolabel, props)] @ keyAndUnit)
   | _ ->
     let children, nonChildrenProps =

tests/ppx/react/expected/forwardRef.res.txt

@@ -166,6 +166,7 @@ module V4A = {
   @react.component
   let make = (_: props) => {
     let input = React.useRef(Js.Nullable.null)
+
     ReactDOM.jsx(
       "div",
       {