-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unpin dependencies #2026
Comments
A few more examples of prettier version conflicts that lead to consumer side's failure |
BTW even the most recent react-email v4 release (a month after the last v3 release) didn't include the merged security fix #1904 and #1949, so I think it is better to unpin the dependencies to decouple the the security updates from the release, and relieve the maintenance burden from the react-email team. |
Good points yeah, I think we'll do this. Will discuss with the team |
Describe the Bug
I tried to find some previous discussions about why the dependencies are pinned but could only find this unanswered question: #921
It's generally considered bad practice to pin dependencies in libraries, pinning dependencies should be done by the consumer. There are a few reasons for this:
react-email
and all could had been fixed with an updated lockfile if the dependencies ofreact-email
were more permissive (Minor or patch version updates). Instead we have to wait forreact-email
to update these.Looking through our list of dependencies (About 150)
react-email
is one of just 3 that have pinned dependencies.Which package is affected (leave empty if unsure)
react-email
Link to the code that reproduces this issue
N/A
To Reproduce
N/A
Expected Behavior
Unpinned
dependencies
with^
(Or at least~
) so that consumers can update minor and patch versions while keepingdevDependencies
pinned.What's your node version? (if relevant)
No response
The text was updated successfully, but these errors were encountered: