Skip to content

Commit 7a2153e

Browse files
Clement Skautvolkert
Clement Skau
authored andcommitted
Adds skip to common_tests.dart test function. Uses it for failing tests. (flutter#121)
1 parent 14ba9ef commit 7a2153e

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

packages/file/test/common_tests.dart

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -98,10 +98,10 @@ void runCommonTests(
9898
void group(String description, void body()) =>
9999
skipIfNecessary(description, () => testpkg.group(description, body));
100100

101-
void test(String description, FutureOr<void> body()) =>
101+
void test(String description, FutureOr<void> body(), {dynamic skip}) =>
102102
skipIfNecessary(description, () {
103103
if (replay == null) {
104-
testpkg.test(description, body);
104+
testpkg.test(description, body, skip: skip);
105105
} else {
106106
group('rerun', () {
107107
testpkg.setUp(() async {
@@ -114,7 +114,7 @@ void runCommonTests(
114114
await Future.forEach(setUps, (SetUpTearDown setUp) => setUp());
115115
});
116116

117-
testpkg.test(description, body);
117+
testpkg.test(description, body, skip: skip);
118118

119119
testpkg.tearDown(() async {
120120
for (SetUpTearDown tearDown in tearDowns) {
@@ -179,7 +179,7 @@ void runCommonTests(
179179
test('considersBothSlashesEquivalent', () {
180180
fs.directory(r'foo\bar_dir').createSync(recursive: true);
181181
expect(fs.directory(r'foo/bar_dir'), exists);
182-
});
182+
}, skip: "Fails due to https://github.com/google/file.dart/issues/112");
183183
});
184184

185185
group('file', () {
@@ -210,7 +210,7 @@ void runCommonTests(
210210
test('considersBothSlashesEquivalent', () {
211211
fs.file(r'foo\bar_file').createSync(recursive: true);
212212
expect(fs.file(r'foo/bar_file'), exists);
213-
});
213+
}, skip: "Fails due to https://github.com/google/file.dart/issues/112");
214214
});
215215

216216
group('link', () {

0 commit comments

Comments
 (0)