Skip to content

Commit d6eaba9

Browse files
authored
Small cleanup tasks. json and proto use the codec abstraction, but the binary serialization does not, other unrelated cleanup (flutter#67)
1 parent dc9516a commit d6eaba9

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
* Split the json codec from info.dart.
1818

19-
* Introduced `lib/binary_codec.dart` a lighterweight
19+
* Introduced `lib/binary_serialization.dart` a lighterweight
2020
serialization/deserialization implementation. This will eventually be used by
2121
default by dart2js.
2222

File renamed without changes.

lib/json_info_codec.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,12 +49,12 @@ class JsonToAllInfoConverter extends Converter<Map<String, dynamic>, AllInfo> {
4949
(elements['constant'] as Map).values.map((c) => parseConstant(c)));
5050

5151
json['holding'].forEach((k, deps) {
52-
var src = registry[k];
52+
CodeInfo src = registry[k];
5353
assert(src != null);
5454
for (var dep in deps) {
5555
var target = registry[dep['id']];
5656
assert(target != null);
57-
(src as CodeInfo).uses.add(new DependencyInfo(target, dep['mask']));
57+
src.uses.add(new DependencyInfo(target, dep['mask']));
5858
}
5959
});
6060

test/binary_codec_test.dart renamed to test/binary_serialization_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import 'dart:convert';
66
import 'dart:io';
77

88
import 'package:dart2js_info/json_info_codec.dart';
9-
import 'package:dart2js_info/binary_codec.dart' as binary;
9+
import 'package:dart2js_info/binary_serialization.dart' as binary;
1010
import 'package:test/test.dart';
1111

1212
class ByteSink implements Sink<List<int>> {

0 commit comments

Comments
 (0)