Deprecate {ion,neutral_atom}.decompose_operation. (quantumlib#4930)

Yet more of quantumlib#4744

Author: MichaelBroughton

Diff for: cirq-core/cirq/ion/ion_device.py

@@ -87,6 +87,9 @@ def qid_pairs(self) -> FrozenSet['cirq.SymmetricalQidPair']:
             qs = self.qubits
             return frozenset([devices.SymmetricalQidPair(q, q2) for q in qs for q2 in qs if q < q2])
 
+    @_compat.deprecated(
+        fix='Use cirq.ConvertToIonGates() instead to decompose operations.', deadline='v0.15'
+    )
     def decompose_operation(self, operation: ops.Operation) -> ops.OP_TREE:
         return convert_to_ion_gates.ConvertToIonGates().convert_one(operation)
 

Diff for: cirq-core/cirq/ion/ion_device_test.py

@@ -81,14 +81,15 @@ def test_init_timedelta():
         _ = d.duration_of(cirq.SingleQubitGate().on(q0))
 
 
-def test_decomposition():
+def test_decomposition_deprecated():
     d = ion_device(3)
     q0 = cirq.LineQubit(0)
     q1 = cirq.LineQubit(1)
-    assert d.decompose_operation(cirq.H(q0)) == [
-        cirq.rx(np.pi * 1.0).on(cirq.LineQubit(0)),
-        cirq.ry(np.pi * -0.5).on(cirq.LineQubit(0)),
-    ]
+    with cirq.testing.assert_deprecated('ConvertToIonGates', deadline='v0.15'):
+        assert d.decompose_operation(cirq.H(q0)) == [
+            cirq.rx(np.pi * 1.0).on(cirq.LineQubit(0)),
+            cirq.ry(np.pi * -0.5).on(cirq.LineQubit(0)),
+        ]
     circuit = cirq.Circuit()
     circuit.append([cirq.X(q0), cirq.CNOT(q0, q1)])
     ion_circuit = d.decompose_circuit(circuit)

Diff for: cirq-core/cirq/neutral_atoms/neutral_atom_devices.py

@@ -16,7 +16,7 @@
 import collections
 from typing import Any, Iterable, cast, DefaultDict, TYPE_CHECKING, FrozenSet
 from numpy import sqrt
-from cirq import devices, ops, circuits, value
+from cirq import _compat, devices, ops, circuits, value
 from cirq.devices.grid_qubit import GridQubit
 from cirq.ops import raw_types
 from cirq.value import Duration
@@ -122,6 +122,10 @@ def qubit_set(self) -> FrozenSet['cirq.GridQubit']:
     def qubit_list(self):
         return [qubit for qubit in self.qubits]
 
+    @_compat.deprecated(
+        fix='Use cirq.ConvertToNeutralAtomGates() instead to decompose operations.',
+        deadline='v0.15',
+    )
     def decompose_operation(self, operation: ops.Operation) -> ops.OP_TREE:
         return convert_to_neutral_atom_gates.ConvertToNeutralAtomGates().convert(operation)
 

Diff for: cirq-core/cirq/neutral_atoms/neutral_atom_devices_test.py

@@ -97,10 +97,11 @@ def test_init_errors():
         )
 
 
-def test_decompose_error():
+def test_decompose_error_deprecated():
     d = square_device(2, 2, holes=[cirq.GridQubit(1, 1)])
-    for op in d.decompose_operation((cirq.CCZ ** 1.5).on(*(d.qubit_list()))):
-        d.validate_operation(op)
+    with cirq.testing.assert_deprecated('ConvertToNeutralAtomGates', deadline='v0.15'):
+        for op in d.decompose_operation((cirq.CCZ ** 1.5).on(*(d.qubit_list()))):
+            d.validate_operation(op)
 
 
 def test_validate_gate_errors():