Skip to content

Commit 89621ac

Browse files
committed
code review changes
1 parent a950092 commit 89621ac

File tree

5 files changed

+9
-8
lines changed

5 files changed

+9
-8
lines changed

packages/antd/src/widgets/SelectWidget/index.tsx

+3-3
Original file line numberDiff line numberDiff line change
@@ -71,11 +71,11 @@ export default function SelectWidget<
7171

7272
const selectOptions: DefaultOptionType[] | undefined = useMemo(() => {
7373
if (Array.isArray(enumOptions)) {
74+
const options = [...enumOptions];
7475
if (!multiple && schema.default === undefined) {
75-
enumOptions.unshift({ value: '', label: placeholder || '' });
76+
options.unshift({ value: '', label: placeholder || '' });
7677
}
77-
78-
return enumOptions.map(({ value: optionValue, label: optionLabel }, index) => ({
78+
return options.map(({ value: optionValue, label: optionLabel }, index) => ({
7979
disabled: Array.isArray(enumDisabled) && enumDisabled.indexOf(optionValue) !== -1,
8080
key: String(index),
8181
value: String(index),

packages/chakra-ui/src/SelectWidget/SelectWidget.tsx

+3-2
Original file line numberDiff line numberDiff line change
@@ -64,10 +64,11 @@ export default function SelectWidget<T = any, S extends StrictRJSFSchema = RJSFS
6464
const _valueLabelMap: any = {};
6565
const displayEnumOptions: OptionsOrGroups<any, any> = useMemo(() => {
6666
if (Array.isArray(enumOptions)) {
67+
const options = [...enumOptions];
6768
if (!multiple && schema.default === undefined) {
68-
enumOptions.unshift({ value: '', label: placeholder || '' });
69+
options.unshift({ value: '', label: placeholder || '' });
6970
}
70-
return enumOptions.map((option: EnumOptionsType<S>, index: number) => {
71+
return options.map((option: EnumOptionsType<S>, index: number) => {
7172
const { value, label } = option;
7273
_valueLabelMap[index] = label || String(value);
7374
return {

packages/chakra-ui/test/__snapshots__/Form.test.tsx.snap

+1-1
Original file line numberDiff line numberDiff line change
@@ -5230,7 +5230,7 @@ exports[`single fields select field single choice formData 1`] = `
52305230
<div
52315231
className=" emotion-7"
52325232
>
5233-
bar
5233+
foo
52345234
</div>
52355235
<div
52365236
className=" emotion-8"

packages/material-ui/src/SelectWidget/SelectWidget.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ export default function SelectWidget<
8686
}}
8787
aria-describedby={ariaDescribedByIds<T>(id)}
8888
>
89-
{!multiple && schema.default === undefined && <MenuItem value=''>{placeholder || ''}</MenuItem>}
89+
{!multiple && schema.default === undefined && <MenuItem value=''>{placeholder}</MenuItem>}
9090
{Array.isArray(enumOptions) &&
9191
enumOptions.map(({ value, label }, i: number) => {
9292
const disabled: boolean = Array.isArray(enumDisabled) && enumDisabled.indexOf(value) !== -1;

packages/mui/src/SelectWidget/SelectWidget.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ export default function SelectWidget<
8989
}}
9090
aria-describedby={ariaDescribedByIds<T>(id)}
9191
>
92-
{!multiple && schema.default === undefined && <MenuItem value=''>{placeholder || ''}</MenuItem>}
92+
{!multiple && schema.default === undefined && <MenuItem value=''>{placeholder}</MenuItem>}
9393
{Array.isArray(enumOptions) &&
9494
enumOptions.map(({ value, label }, i: number) => {
9595
const disabled: boolean = Array.isArray(enumDisabled) && enumDisabled.indexOf(value) !== -1;

0 commit comments

Comments
 (0)