Skip to content

Title in additionalProperties replaces real value #2709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
v1ack opened this issue Feb 15, 2022 · 4 comments
Closed
3 tasks done

Title in additionalProperties replaces real value #2709

v1ack opened this issue Feb 15, 2022 · 4 comments
Labels

Comments

@v1ack
Copy link
Contributor

v1ack commented Feb 15, 2022

Prerequisites

Description

Screenshot_20220215_152934

If additional properties have title it will replace real key

Steps to Reproduce

Reprodusing link

  1. Set up scheme with title in additional properties
  2. Set formdata with any key

Expected behavior

I expected to see real key in input

Actual behavior

I see title of model instead of value

After deleting title it looks good

Screenshot_20220215_154058

Version

3.2.1

@alfonsoar alfonsoar added the bug label Feb 19, 2022
@gturmel
Copy link

gturmel commented Mar 25, 2022

@v1ack I don't think that this is a bug, I think this is working as intended. Definitions are intended to create a small, repeatable schema that can be referenced, without having to copy/paste the same piece of JSON over and over again. As the definition is supposed to be broad and generic, explicitly including a title lets us know that this title should be included for every place the definition is referenced.

@v1ack
Copy link
Contributor Author

v1ack commented Mar 26, 2022

@gturmel I agree about title, but rewriting the real value can't be intended

@gturmel
Copy link

gturmel commented Mar 28, 2022

@v1ack Can you elaborate more about what you mean by rewriting the real value? From my understanding of RJSF, formData is generated, rather than used as a source of truth. The title set in definitions would be the real value.

@v1ack
Copy link
Contributor Author

v1ack commented Sep 16, 2022

fixed in #2878

@v1ack v1ack closed this as completed Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants