incorrect default value for an array with minItems and no default for the items

[anthonycaron]

Prerequisites

• I have searched the existing issues
• I understand that providing a SSCCE example is tremendously useful to the maintainers.
• I have read the documentation
• Ideally, I'm providing a sample JSFiddle, Codesandbox.io or preferably a shared playground link demonstrating the issue.

What theme are you using?

core

Version

latest

Current Behavior

Given this schema:

const schema: RJSFSchema = {
  type: 'object',
  properties: {
    optionalArray: {
      type: 'array',
      minItems: 2,
      items: { type: 'string' },
    },
  },
};

And given the raw form data with a value of {},
I believe the resulting data after processing the default values should be { optionalArray: undefined } since the optionalArray property is declared in the schema hence I guess we expect to have in our resulting data, but with a value of undefined since it's optional. ajv would consider the data as valid in that case.

As you can see in the playground, the value returned is:

{
  "optionalArray": [
    null,
    null
  ]
}

And when running the following test

it('should return partial array for an optional array property with minItems when provided with a partial array', () => {
  const schema: RJSFSchema = {
    type: 'object',
    properties: {
      optionalArray: {
        type: 'array',
        minItems: 2,
        items: { type: 'string' },
      },
    },
  };
  expect(
    computeDefaults(testValidator, schema, {
      rootSchema: schema,
      rawFormData: {},
      behaviorBitFlags: DefaultFormStateBehavior.IgnoreMinItemsUnlessRequired,
    })
  ).toEqual({ optionalArray: undefined });
});

in getDefaultFormStateTest.ts, we have the following result:

{
  "optionalArray": [
    undefined,
    undefined
  ]
}

I guess this is because I'm running this test on the latest version of the codebase and the playground might be using the latest release.
In any case, the issue is there.

Expected Behavior

This test should pass:

it('should return partial array for an optional array property with minItems when provided with a partial array', () => {
  const schema: RJSFSchema = {
    type: 'object',
    properties: {
      optionalArray: {
        type: 'array',
        minItems: 2,
        items: { type: 'string' },
      },
    },
  };
  expect(
    computeDefaults(testValidator, schema, {
      rootSchema: schema,
      rawFormData: {},
      behaviorBitFlags: DefaultFormStateBehavior.IgnoreMinItemsUnlessRequired,
    })
  ).toEqual({ optionalArray: undefined });
});

Steps To Reproduce

You can try it in the playground

Or

1. fork the repo
2. run npm i
3. add the test I put up here in the packages/utils/test/schema/getDefaultFormStateTest.ts file
4. run npm run test

Environment

- OS: MacOS Ventura
- Node: 18.7.0
- npm: 8.15.0

Anything else?

No response

[anthonycaron]

Just for context, there's a discussion regarding this here.

[heath-freenome]

@anthonycaron The playground editors will convert the [undefined, undefined] array into [null, null] so that is expected behavior. Also, once we release 5.7.0 (soon!), the new experimental_DefaultFormStateBehavior.arrayMinItems: 'requiredOnly' flag being added to the Form could also fix this. Would you be willing to take another look at this once we release?

[anthonycaron]

Sure, thank you !

[stale]

This issue was closed because of lack of recent activity. Reoopen if you still need assistance.