Update to Tika 1.8

Tika 1.8 has been released. See https://dist.apache.org/repos/dist/release/tika/CHANGES-1.8.txt

We can replace:

```java
public static boolean isLocaleCompatible() {
    String language = Locale.getDefault().getLanguage();
    boolean acceptedLocale = true;

    if (
        // We can have issues with JDK7 Patch < 80
            (JVM_MAJOR_VERSION == 1 && JVM_MINOR_VERSION == 7 && JVM_PATCH_MAJOR_VERSION == 0 && JVM_PATCH_MINOR_VERSION < 80) ||
                    // We can have issues with JDK8 Patch < 40
                    (JVM_MAJOR_VERSION == 1 && JVM_MINOR_VERSION == 8 && JVM_PATCH_MAJOR_VERSION == 0 && JVM_PATCH_MINOR_VERSION < 40)
            ) {
        if (language.equalsIgnoreCase("tr") || language.equalsIgnoreCase("az")) {
            acceptedLocale = false;
        }
    }

    return acceptedLocale;
}
```

by

```java
public static boolean isLocaleCompatible() {
    return true;
}
```

Related to https://issues.apache.org/jira/browse/TIKA-1526 and elastic#105

Note that Content-type has changed a bit and now returns something like `application/xhtml+xml; charset=ISO-8859-1` instead of `application/xhtml+xml`.

Closes elastic#112.
(cherry picked from commit bf4af47971ed07bfa126409413c435f121444c3c)

Author: dadoonet

pom.xml

@@ -57,7 +57,7 @@
         <dependency>
             <groupId>org.apache.tika</groupId>
             <artifactId>tika-parsers</artifactId>
-            <version>1.7</version>
+            <version>1.8</version>
             <exclusions>
                 <!-- Not Apache2 License compatible -->
                 <exclusion>

src/main/java/org/elasticsearch/plugin/mapper/attachments/tika/LocaleChecker.java

@@ -21,7 +21,6 @@
 
 import org.apache.lucene.util.Constants;
 
-import java.util.Locale;
 import java.util.StringTokenizer;
 
 import static java.lang.Integer.parseInt;
@@ -46,24 +45,9 @@ public class LocaleChecker {
     }
 
     /**
-     * We can have issues with some JVMs and Locale
-     * See https://github.com/elasticsearch/elasticsearch-mapper-attachments/issues/105
+     * Tika 1.8 fixed currently known Locale issues with some JVMs
      */
     public static boolean isLocaleCompatible() {
-        String language = Locale.getDefault().getLanguage();
-        boolean acceptedLocale = true;
-
-        if (
-            // We can have issues with JDK7 Patch < 80
-                (JVM_MAJOR_VERSION == 1 && JVM_MINOR_VERSION == 7 && JVM_PATCH_MAJOR_VERSION == 0 && JVM_PATCH_MINOR_VERSION < 80) ||
-                        // We can have issues with JDK8 Patch < 40
-                        (JVM_MAJOR_VERSION == 1 && JVM_MINOR_VERSION == 8 && JVM_PATCH_MAJOR_VERSION == 0 && JVM_PATCH_MINOR_VERSION < 40)
-                ) {
-            if (language.equalsIgnoreCase("tr") || language.equalsIgnoreCase("az")) {
-                acceptedLocale = false;
-            }
-        }
-
-        return acceptedLocale;
+        return true;
     }
 }

src/test/java/org/elasticsearch/index/mapper/attachment/test/unit/SimpleAttachmentMapperTests.java

@@ -31,8 +31,7 @@
 import static org.elasticsearch.common.io.Streams.copyToBytesFromClasspath;
 import static org.elasticsearch.common.io.Streams.copyToStringFromClasspath;
 import static org.elasticsearch.common.xcontent.XContentFactory.jsonBuilder;
-import static org.hamcrest.Matchers.containsString;
-import static org.hamcrest.Matchers.equalTo;
+import static org.hamcrest.Matchers.*;
 
 /**
  *
@@ -57,7 +56,7 @@ public void testSimpleMappings() throws Exception {
 
         ParseContext.Document doc = docMapper.parse(json).rootDoc();
 
-        assertThat(doc.get(docMapper.mappers().getMapper("file.content_type").names().indexName()), equalTo("application/xhtml+xml"));
+        assertThat(doc.get(docMapper.mappers().getMapper("file.content_type").names().indexName()), startsWith("application/xhtml+xml"));
         assertThat(doc.get(docMapper.mappers().getMapper("file.title").names().indexName()), equalTo("XHTML test document"));
         assertThat(doc.get(docMapper.mappers().getMapper("file").names().indexName()), containsString("This document tests the ability of Apache Tika to extract content"));
 
@@ -69,7 +68,7 @@ public void testSimpleMappings() throws Exception {
 
         doc = docMapper.parse(json).rootDoc();
 
-        assertThat(doc.get(docMapper.mappers().getMapper("file.content_type").names().indexName()), equalTo("application/xhtml+xml"));
+        assertThat(doc.get(docMapper.mappers().getMapper("file.content_type").names().indexName()), startsWith("application/xhtml+xml"));
         assertThat(doc.get(docMapper.mappers().getMapper("file.title").names().indexName()), equalTo("XHTML test document"));
         assertThat(doc.get(docMapper.mappers().getMapper("file").names().indexName()), containsString("This document tests the ability of Apache Tika to extract content"));
     }