Fix "Unknown option: help" not being displayed

rmunn · rmunn · commit aa680a237772 · 2020-06-02T14:09:28.000+07:00
This fixes commandlineparser#596.
diff --git a/src/CommandLine/ErrorExtensions.cs b/src/CommandLine/ErrorExtensions.cs
@@ -19,9 +19,7 @@ public static ParserResult<T> ToParserResult<T>(this IEnumerable<Error> errors,
         public static IEnumerable<Error> OnlyMeaningfulOnes(this IEnumerable<Error> errors)
         {
             return errors
-                .Where(e => !e.StopsProcessing)
-                .Where(e => !(e.Tag == ErrorType.UnknownOptionError
-                    && ((UnknownOptionError)e).Token.EqualsOrdinalIgnoreCase("help")));
+                .Where(e => !e.StopsProcessing);
         }
        
     }

Original file line number	Diff line number	Diff line change
`@@ -19,9 +19,7 @@ public static ParserResult<T> ToParserResult<T>(this IEnumerable<Error> errors,`
`19`	`19`	`public static IEnumerable<Error> OnlyMeaningfulOnes(this IEnumerable<Error> errors)`
`20`	`20`	`{`
`21`	`21`	`return errors`
`22`		`- .Where(e => !e.StopsProcessing)`
`23`		`- .Where(e => !(e.Tag == ErrorType.UnknownOptionError`
`24`		`- && ((UnknownOptionError)e).Token.EqualsOrdinalIgnoreCase("help")));`
	`22`	`+ .Where(e => !e.StopsProcessing);`
`25`	`23`	`}`
`26`	`24`
`27`	`25`	`}`