Skip to content

Commit 286f221

Browse files
committed
remove async compiler pass check/add due to "AddTopicMetaPass" removal upstream in php-enqueue/enqueue-dev#534 and remove non-dtd-compliant "syntaxCheck" phpunit config XML root attribute
1 parent bcfb68e commit 286f221

File tree

3 files changed

+2
-9
lines changed

3 files changed

+2
-9
lines changed

LiipImagineBundle.php

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@
1111

1212
namespace Liip\ImagineBundle;
1313

14-
use Enqueue\Bundle\DependencyInjection\Compiler\AddTopicMetaPass;
15-
use Liip\ImagineBundle\Async\Topics;
1614
use Liip\ImagineBundle\DependencyInjection\Compiler\DriverCompilerPass;
1715
use Liip\ImagineBundle\DependencyInjection\Compiler\FiltersCompilerPass;
1816
use Liip\ImagineBundle\DependencyInjection\Compiler\LoadersCompilerPass;
@@ -46,12 +44,6 @@ public function build(ContainerBuilder $container)
4644
$container->addCompilerPass(new ResolversCompilerPass());
4745
$container->addCompilerPass(new MetadataReaderCompilerPass());
4846

49-
if (class_exists(AddTopicMetaPass::class)) {
50-
$container->addCompilerPass(AddTopicMetaPass::create()
51-
->add(Topics::CACHE_RESOLVED, 'The topic contains messages about resolved image\'s caches')
52-
);
53-
}
54-
5547
/** @var $extension LiipImagineExtension */
5648
$extension = $container->getExtension('liip_imagine');
5749

composer.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
},
3232
"require-dev": {
3333
"ext-gd": "*",
34+
"ext-json": "*",
3435
"amazonwebservices/aws-sdk-for-php": "^1.0",
3536
"aws/aws-sdk-php": "^2.4",
3637
"doctrine/cache": "^1.1",
@@ -60,6 +61,7 @@
6061
"aws/aws-sdk-php": "required to use AWS version 2/3 cache resolver",
6162
"doctrine/mongodb-odm": "required to use mongodb-backed doctrine components",
6263
"enqueue/enqueue-bundle": "^0.9 add if you like to process images in background",
64+
"ext-json": "required for enqueue/bundle library code",
6365
"league/flysystem": "required to use FlySystem data loader or cache resolver",
6466
"monolog/monolog": "A psr/log compatible logger is required to enable logging",
6567
"twig/twig": "required to use the provided Twig extension. Version 1.12 or greater needed"

phpunit.xml.dist

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
convertErrorsToExceptions="true"
88
convertNoticesToExceptions="true"
99
convertWarningsToExceptions="true"
10-
syntaxCheck="true"
1110
forceCoversAnnotation="true"
1211
bootstrap="./Tests/bootstrap.php">
1312

0 commit comments

Comments
 (0)