-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(builder): add support to nested filters #141
Conversation
That's a good step forward, thanks! Only problem I can see is the lack of CRUD, which I like to implement for anything. |
@Peter-Krebs I'm afraid I didn't understand. Can you open a new issue for this, so we could discuss more about it? |
@Peter-Krebs This PR is only related to nested filters support. Any other improvement will be handle in a new PR. |
@JoaoPedroAS51 Yes I'm talking about the filters. Consider this call: It would be nice to modify filters as well instead of just replacing the whole value. |
@Peter-Krebs I'm afraid that making such change would break the current structure we are following in this package, which I believe was inspired by Laravel’s Eloquent. Maybe you could provide an usage example where adding and removing filters would be useful. That way we can think together in a solution :) I recommend opening a new issue to discuss about this, because such change is outside the scope of this PR. What do you think @robsontenorio? |
I think we can get started with the simple solution. |
ff793b2
to
b2ae126
Compare
🎉 This PR is included in version 1.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Seems like solution does not support two nested values or am I doing something wrong? query.where(['schedule', 'start'], start)
.where(['schedule', 'end'], end) |
Hi @dionysiosarvanitis! Thank you for your report. I'm working on a fix for your issue :) |
@dionysiosarvanitis Done #154 😉 |
@JoaoPedroAS51 that was really quick! Thank you! |
Add support to nested filters to
where
andwhereIn
.Closes #81
TODO
where
andwhereIn
Usage