Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(model): add support to upload files #143

Merged
merged 27 commits into from
Nov 10, 2020
Merged

feat(model): add support to upload files #143

merged 27 commits into from
Nov 10, 2020

Conversation

JoaoPedroAS51
Copy link
Collaborator

@JoaoPedroAS51 JoaoPedroAS51 commented Nov 6, 2020 •
edited
Loading

Add support to upload files by checking if data has instance of File. If so, it set the Content-Type to multipart/form-data and convert the data object to FormData using object-to-formdata.

Require #142

Based on comment by @alvaro-canepa at #83

Closes #83

TODO

  • Update documentation
  • Update tests
  • Add dependency object-to-formdata

@JoaoPedroAS51 JoaoPedroAS51 marked this pull request as draft November 6, 2020 01:43
@robsontenorio
Copy link
Owner

Beautiful!

I know there are some gotchas behind FormData, I can’t remember right know. But, it is a optional feature and there are no breaking changes, looks good for me. Let’s try it.

Please, wait reviews from #142

robsontenorio
robsontenorio reviewed Nov 6, 2020
View reviewed changes
robsontenorio
robsontenorio reviewed Nov 6, 2020
View reviewed changes
@JoaoPedroAS51
revert: "feat(model): add updateMethod option"
a2553f9 
This reverts commit 6baffaf
@JoaoPedroAS51
Merge branch 'feat/config' into feat/files
f20f6be
@JoaoPedroAS51
revert: "feat(utils): add serialize utility"
20906dd 
This reverts commit 4daf501
@JoaoPedroAS51
chore(deps): add dependency object-to-formdata
7a584a0
@JoaoPedroAS51
fix(model): import serialize from object-to-formdata
63261ef
@JoaoPedroAS51
docs: add config docs
8908543
@JoaoPedroAS51
Merge branch 'feat/config' into feat/files
b57a5a1
@JoaoPedroAS51
docs: use alert type success for "available in version"
4193f9a
@JoaoPedroAS51
Merge branch 'dev' into feat/config
2dd0630
@JoaoPedroAS51
Merge branch 'feat/config' into feat/files
a0e9ed3 
# Conflicts:
#	package.json
#	src/Model.js
@JoaoPedroAS51
test(model): update test message
5ba661d
@JoaoPedroAS51
feat(model): add method patch
68a4675 
Alias for `Model.config({ method: 'PATCH' }).save()`
@JoaoPedroAS51
docs: add docs of patch method
10f3535
@JoaoPedroAS51
Merge branch 'feat/config' into feat/files
b1ebf43
@JoaoPedroAS51 JoaoPedroAS51 marked this pull request as ready for review November 9, 2020 21:12
@JoaoPedroAS51 JoaoPedroAS51 merged commit a93cf5e into dev Nov 10, 2020
@JoaoPedroAS51 JoaoPedroAS51 deleted the feat/files branch November 10, 2020 01:09
@Peter-Krebs
Copy link
Collaborator

Thanks for taking the time to implement @JoaoPedroAS51 that was a long awaited feature 🚀

@github-actions
Copy link

🎉 This PR is included in version 1.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robsontenorio robsontenorio robsontenorio approved these changes

@Peter-Krebs Peter-Krebs Awaiting requested review from Peter-Krebs

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upload a PDF file
3 participants
@JoaoPedroAS51 @robsontenorio @Peter-Krebs