chore(all): fix lint issues (#1270)

Author: lukastaegert

.github/workflows/node-windows.yml

@@ -36,10 +36,10 @@ jobs:
           node-version: ${{ matrix.node }}
 
       - name: install pnpm
-        run: npm install pnpm@6 -g
+        run: npm install pnpm@7 -g
 
       - name: pnpm install
         run: pnpm install --ignore-scripts
 
       - name: run tests
-        run: pnpm ci:test --filter "...[origin/master]"
+        run: pnpm --filter "...[origin/master]" ci:test

.github/workflows/release.yml

@@ -43,7 +43,7 @@ jobs:
 
       - name: Install pnpm
         run: |
-          npm install pnpm@6 -g;
+          npm install pnpm@7 -g;
           echo node `pnpm -v`;
 
       - name: Set Git Config
@@ -57,16 +57,16 @@ jobs:
         run: pnpm install
 
       - name: Build Packages
-        run: pnpm build --recursive
+        run: pnpm --recursive build
 
       - name: Lint Monorepo
         run: pnpm lint
 
       - name: Run Tests
-        run: pnpm test --filter [HEAD^]
+        run: pnpm --filter [HEAD^] test
 
       - name: Release and Publish Packages
-        run: pnpm release --filter [HEAD^]
+        run: pnpm --filter [HEAD^] release
         env:
           NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN}}
           NPM_TOKEN: ${{ secrets.NPM_TOKEN }}

.github/workflows/validate.yml

@@ -34,7 +34,7 @@ jobs:
         run: git branch -f master origin/master
 
       - name: Install pnpm
-        run: npm install pnpm@6 -g
+        run: npm install pnpm@7 -g
 
       - name: Sanity Check
         run: |
@@ -53,10 +53,10 @@ jobs:
       #   run: pnpm security
 
       - name: Build Packages
-        run: pnpm build --recursive
+        run: pnpm --recursive build
 
       - name: Lint Monorepo
         run: pnpm lint:js
 
       - name: Run Tests
-        run: pnpm ci:coverage --filter "...[origin/master]"
+        run: pnpm --filter "...[origin/master]" ci:coverage

.npmrc

@@ -4,3 +4,4 @@ enable-pre-post-scripts = true
 link-workspace-packages = false
 shamefully-hoist = true
 shared-workspace-shrinkwrap = true
+strict-peer-dependencies = false

README.md

@@ -73,15 +73,15 @@ All plugin packages are kept in the `/packages` directory.
 #### Adding dependencies:
 
 ```console
-$ pnpm add <package> --filter ./packages/<name>
+$ pnpm --filter ./packages/<name> add <package>
 ```
 
 Where `<package>` is the name of the NPM package you wish to add for a plugin package, and `<name>` is the proper name of the plugin. e.g. `@rollup/plugin-beep`.
 
 #### Publishing:
 
 ```console
-$ pnpm publish -- <name> [flags]
+$ pnpm publish <name> [flags]
 ```
 
 Where `<name>` is the portion of the plugin package name following `@rollup/plugin-`. (e.g. `beep`)
@@ -118,7 +118,7 @@ $ pnpm test
 To run tests on a specific package:
 
 ```console
-$ pnpm test --filter ./packages/<name>
+$ pnpm --filter ./packages/<name> test
 ```
 
 Linting:
@@ -132,10 +132,10 @@ $ pnpm lint
 To lint a specific package:
 
 ```console
-$ pnpm lint --filter ./packages/<name>
+$ pnpm --filter ./packages/<name> lint
 ```
 
-_Note: Scripts in the repository will run the root `test` and `lint` script on those packages which have changes. This is also how the CI pipelines function. To run either on a package outside of that pipeline, use `pnpm <script> -- @rollup/plugin-<name>`._
+_Note: Scripts in the repository will run the root `test` and `lint` script on those packages which have changes. This is also how the CI pipelines function. To run either on a package outside of that pipeline, use `pnpm <script> @rollup/plugin-<name>`._
 
 ## Adding Plugins
 

package.json

@@ -36,7 +36,7 @@
     "husky": "8.0.1",
     "lint-staged": "11.0.1",
     "nyc": "^15.1.0",
-    "pnpm": "6.10.0",
+    "pnpm": "^7.12.2",
     "prettier": "^2.2.1",
     "prettier-plugin-package": "^1.3.0",
     "semver": "^7.3.2",

packages/alias/package.json

@@ -28,7 +28,7 @@
     "prepare": "if [ ! -d 'dist' ]; then pnpm build; fi",
     "prerelease": "pnpm build",
     "pretest": "pnpm build",
-    "release": "pnpm plugin:release --workspace-root -- --pkg $npm_package_name",
+    "release": "pnpm --workspace-root plugin:release --pkg $npm_package_name",
     "test": "ava",
     "test:ts": "tsc --noEmit"
   },

packages/auto-install/package.json

@@ -25,7 +25,7 @@
     "prepare": "if [ ! -d 'dist' ]; then pnpm build; fi",
     "prerelease": "pnpm build",
     "pretest": "pnpm build",
-    "release": "pnpm plugin:release --workspace-root -- --pkg $npm_package_name",
+    "release": "pnpm --workspace-root plugin:release --pkg $npm_package_name",
     "test": "ava",
     "test:ts": "tsc --noEmit"
   },

packages/babel/package.json

@@ -27,7 +27,7 @@
     "prebuild": "del-cli dist",
     "prerelease": "pnpm build",
     "pretest": "pnpm build",
-    "release": "pnpm plugin:release --workspace-root -- --pkg $npm_package_name",
+    "release": "pnpm --workspace-root plugin:release --pkg $npm_package_name",
     "test": "ava",
     "test:ts": "tsc types/index.d.ts test/types.ts --noEmit"
   },

packages/babel/test/as-input-plugin.js

@@ -3,7 +3,6 @@ import * as fs from 'fs';
 
 import test from 'ava';
 import { rollup } from 'rollup';
-import { SourceMapConsumer } from 'source-map';
 import jsonPlugin from '@rollup/plugin-json';
 import nodeResolvePlugin from '@rollup/plugin-node-resolve';
 import { createFilter } from '@rollup/pluginutils';
@@ -172,7 +171,15 @@ test('generates sourcemap by default', async (t) => {
   } = await bundle.generate({ format: 'cjs', exports: 'auto', sourcemap: true });
 
   const target = 'log';
+
+  // source-map uses the presence of fetch to detect browser environments which
+  // breaks in Node 18
+  const { fetch } = global;
+  delete global.fetch;
+  const { SourceMapConsumer } = await import('source-map');
   const smc = await new SourceMapConsumer(map);
+  global.fetch = fetch;
+
   const loc = getLocation(code, code.indexOf(target));
   const original = smc.originalPositionFor(loc);
 

packages/babel/test/as-output-plugin.js

@@ -2,7 +2,6 @@ import * as nodePath from 'path';
 
 import test from 'ava';
 import { rollup } from 'rollup';
-import { SourceMapConsumer } from 'source-map';
 
 import { getCode } from '../../../util/test';
 
@@ -130,7 +129,15 @@ test('generates sourcemap by default', async (t) => {
   });
 
   const target = 'log';
+
+  // source-map uses the presence of fetch to detect browser environments which
+  // breaks in Node 18
+  const { fetch } = global;
+  delete global.fetch;
+  const { SourceMapConsumer } = await import('source-map');
   const smc = await new SourceMapConsumer(map);
+  global.fetch = fetch;
+
   const loc = getLocation(code, code.indexOf(target));
   const original = smc.originalPositionFor(loc);
 

packages/babel/test/fixtures/proposal-decorators/main.js

@@ -1,3 +1,5 @@
+/* eslint-disable @typescript-eslint/no-unused-vars */
+
 @annotation
 export default class MyClass {}
 

packages/buble/package.json

@@ -28,7 +28,7 @@
     "prepare": "if [ ! -d 'dist' ]; then pnpm build; fi",
     "prerelease": "pnpm build",
     "pretest": "pnpm build",
-    "release": "pnpm plugin:release --workspace-root -- --pkg $npm_package_name",
+    "release": "pnpm --workspace-root plugin:release --pkg $npm_package_name",
     "test": "ava",
     "test:ts": "tsc types/index.d.ts test/types.ts --noEmit"
   },

packages/commonjs/package.json

@@ -33,7 +33,7 @@
     "prepublishOnly": "pnpm build",
     "prerelease": "pnpm build",
     "pretest": "pnpm build",
-    "release": "pnpm plugin:release --workspace-root -- --pkg $npm_package_name",
+    "release": "pnpm --workspace-root plugin:release --pkg $npm_package_name",
     "test": "ava",
     "test:ts": "tsc types/index.d.ts test/types.ts --noEmit"
   },

packages/commonjs/test/test.js

@@ -62,12 +62,15 @@ test('generates a sourcemap', async (t) => {
     sourcemapFile: path.resolve('bundle.js')
   });
 
-  // Hack to make it work on Node 18
+  // source-map uses the presence of fetch to detect browser environments which
+  // breaks in Node 18
+  const { fetch } = global;
   delete global.fetch;
   const { SourceMapConsumer } = await import('source-map');
   const smc = await new SourceMapConsumer(map);
-  const locator = getLocator(code, { offsetLine: 1 });
+  global.fetch = fetch;
 
+  const locator = getLocator(code, { offsetLine: 1 });
   let generatedLoc = locator('42');
   let loc = smc.originalPositionFor(generatedLoc); // 42
   t.is(loc.source, 'fixtures/samples/sourcemap/foo.js');

packages/data-uri/package.json

@@ -26,8 +26,8 @@
     "ci:test": "pnpm test -- --verbose",
     "prebuild": "del-cli dist",
     "prerelease": "pnpm build",
-    "pretest": "pnpm build -- --sourcemap",
-    "release": "pnpm plugin:release --workspace-root -- --pkg $npm_package_name",
+    "pretest": "pnpm build --sourcemap",
+    "release": "pnpm --workspace-root plugin:release --pkg $npm_package_name",
     "test": "ava",
     "test:ts": "tsc --noEmit"
   },

packages/dsv/package.json

@@ -25,7 +25,7 @@
     "prepare": "if [ ! -d 'dist' ]; then pnpm build; fi",
     "prerelease": "pnpm build",
     "pretest": "pnpm build",
-    "release": "pnpm plugin:release --workspace-root -- --pkg $npm_package_name",
+    "release": "pnpm --workspace-root plugin:release --pkg $npm_package_name",
     "test": "ava"
   },
   "files": [

packages/dynamic-import-vars/package.json

@@ -26,8 +26,8 @@
     "ci:test": "pnpm test -- --verbose",
     "prebuild": "del-cli dist",
     "prerelease": "pnpm build",
-    "pretest": "pnpm build -- --sourcemap",
-    "release": "pnpm plugin:release --workspace-root -- --pkg $npm_package_name",
+    "pretest": "pnpm build --sourcemap",
+    "release": "pnpm --workspace-root plugin:release --pkg $npm_package_name",
     "test": "ava"
   },
   "files": [

packages/eslint/package.json

@@ -28,7 +28,7 @@
     "prepare": "if [ ! -d 'dist' ]; then pnpm build; fi",
     "prerelease": "pnpm build",
     "pretest": "pnpm build",
-    "release": "pnpm plugin:release --workspace-root -- --pkg $npm_package_name",
+    "release": "pnpm --workspace-root plugin:release --pkg $npm_package_name",
     "test": "ava",
     "test:ts": "tsc --noEmit"
   },

packages/graphql/package.json

@@ -26,7 +26,7 @@
     "prepare": "if [ ! -d 'dist' ]; then pnpm build; fi",
     "prerelease": "pnpm build",
     "pretest": "pnpm build",
-    "release": "pnpm plugin:release --workspace-root -- --pkg $npm_package_name",
+    "release": "pnpm --workspace-root plugin:release --pkg $npm_package_name",
     "test": "ava",
     "test:ts": "tsc types/index.d.ts test/types.ts --noEmit"
   },

packages/html/package.json

@@ -27,7 +27,7 @@
     "prebuild": "del-cli dist",
     "prerelease": "pnpm build",
     "pretest": "pnpm build",
-    "release": "pnpm plugin:release --workspace-root -- --pkg $npm_package_name",
+    "release": "pnpm --workspace-root plugin:release --pkg $npm_package_name",
     "test": "ava",
     "test:ts": "tsc --noEmit"
   },

packages/image/package.json

@@ -28,7 +28,7 @@
     "prepare": "if [ ! -d 'dist' ]; then pnpm build; fi",
     "prerelease": "pnpm build",
     "pretest": "pnpm build",
-    "release": "pnpm plugin:release --workspace-root -- --pkg $npm_package_name",
+    "release": "pnpm --workspace-root plugin:release --pkg $npm_package_name",
     "test": "ava"
   },
   "files": [

packages/inject/package.json

@@ -25,7 +25,7 @@
     "prepare": "if [ ! -d 'dist' ]; then pnpm build; fi",
     "prerelease": "pnpm build",
     "pretest": "pnpm build",
-    "release": "pnpm plugin:release --workspace-root -- --pkg $npm_package_name",
+    "release": "pnpm --workspace-root plugin:release --pkg $npm_package_name",
     "test": "ava",
     "test:ts": "tsc index.d.ts test/types.ts --noEmit"
   },

packages/json/package.json

@@ -25,7 +25,7 @@
     "prepare": "if [ ! -d 'dist' ]; then pnpm build; fi",
     "prerelease": "pnpm build",
     "pretest": "pnpm build",
-    "release": "pnpm plugin:release --workspace-root -- --pkg $npm_package_name",
+    "release": "pnpm --workspace-root plugin:release --pkg $npm_package_name",
     "test": "ava",
     "test:ts": "tsc types/index.d.ts test/types.ts --noEmit"
   },

packages/legacy/package.json

@@ -25,7 +25,7 @@
     "prepare": "if [ ! -d 'dist' ]; then pnpm build; fi",
     "prerelease": "pnpm build",
     "pretest": "pnpm build",
-    "release": "pnpm plugin:release --workspace-root -- --pkg $npm_package_name",
+    "release": "pnpm --workspace-root plugin:release --pkg $npm_package_name",
     "test": "ava"
   },
   "files": [

packages/multi-entry/package.json

@@ -28,7 +28,7 @@
     "prepare": "if [ ! -d 'dist' ]; then pnpm build; fi",
     "prerelease": "pnpm build",
     "pretest": "pnpm build",
-    "release": "pnpm plugin:release --workspace-root -- --pkg $npm_package_name",
+    "release": "pnpm --workspace-root plugin:release --pkg $npm_package_name",
     "test": "ava"
   },
   "files": [

packages/node-resolve/package.json

@@ -28,14 +28,14 @@
     "ci:coverage": "nyc pnpm test && nyc report --reporter=text-lcov > coverage.lcov",
     "ci:lint": "pnpm build && pnpm lint",
     "ci:lint:commits": "commitlint --from=${CIRCLE_BRANCH} --to=${CIRCLE_SHA1}",
-    "ci:test": "pnpm test -- --verbose && pnpm test:ts",
+    "ci:test": "pnpm test -- --verbose",
     "prebuild": "del-cli dist",
     "prepare": "if [ ! -d 'dist' ]; then pnpm build; fi",
     "prepublishOnly": "pnpm build",
     "prerelease": "pnpm build",
     "pretest": "pnpm build",
-    "release": "pnpm plugin:release --workspace-root -- --pkg $npm_package_name",
-    "test": "ava && pnpm test:ts",
+    "release": "pnpm --workspace-root plugin:release --pkg $npm_package_name",
+    "test": "pnpm test:ts && ava",
     "test:ts": "tsc types/index.d.ts test/types.ts --noEmit"
   },
   "files": [

packages/pluginutils/package.json

@@ -34,8 +34,8 @@
     "prebuild": "del-cli dist",
     "prepare": "if [ ! -d 'dist' ]; then pnpm build; fi",
     "prerelease": "pnpm build",
-    "pretest": "pnpm build -- --sourcemap",
-    "release": "pnpm plugin:release --workspace-root -- --pkg $npm_package_name",
+    "pretest": "pnpm build --sourcemap",
+    "release": "pnpm --workspace-root plugin:release --pkg $npm_package_name",
     "test": "ava",
     "test:ts": "tsc --noEmit"
   },

packages/pluginutils/src/dataToEsm.ts

@@ -52,6 +52,7 @@ function serialize(obj: unknown, indent: Indent, baseIndent: string): string {
   }
   if (typeof obj === 'symbol') {
     const key = Symbol.keyFor(obj);
+    // eslint-disable-next-line no-undefined
     if (key !== undefined) return `Symbol.for(${stringify(key)})`;
   }
   if (typeof obj === 'bigint') return `${obj}n`;

packages/replace/package.json

@@ -25,7 +25,7 @@
     "prepare": "if [ ! -d 'dist' ]; then pnpm build; fi",
     "prerelease": "pnpm build",
     "pretest": "pnpm build",
-    "release": "pnpm plugin:release --workspace-root -- --pkg $npm_package_name",
+    "release": "pnpm --workspace-root plugin:release --pkg $npm_package_name",
     "test": "ava",
     "test:ts": "tsc types/index.d.ts test/types.ts --noEmit"
   },

packages/replace/test/sourcemaps.js

@@ -2,9 +2,14 @@
 
 const test = require('ava');
 const { rollup } = require('rollup');
-const { SourceMapConsumer } = require('source-map');
 const { getLocator } = require('locate-character');
+// source-map uses the presence of fetch to detect browser environments which
+// breaks in Node 18
+const { fetch } = global;
+delete global.fetch;
+const { SourceMapConsumer } = require('source-map');
 
+global.fetch = fetch;
 const replace = require('../dist/rollup-plugin-replace.cjs.js');
 
 const { getOutputFromGenerated } = require('./helpers/util');