Skip to content

Commit b1c4a17

Browse files
authored
Stop recommending node-builtins (#4190)
* Stop recommending node-builtins. Closes #2881 * Update all occurrences of node-polyfills.
1 parent 08655bc commit b1c4a17

File tree

5 files changed

+5
-5
lines changed

5 files changed

+5
-5
lines changed

cli/run/batchWarnings.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ const immediateHandlers: {
7878
stderr(
7979
`Creating a browser bundle that depends on ${printQuotedStringList(
8080
warning.modules!
81-
)}. You might need to include https://github.com/ionic-team/rollup-plugin-node-polyfills`
81+
)}. You might need to include https://github.com/snowpackjs/rollup-plugin-polyfill-node`
8282
);
8383
},
8484

docs/08-troubleshooting.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ export default {
9191

9292
If you *do* want to include the module in your bundle, you need to tell Rollup how to find it. In most cases, this is a question of using [@rollup/plugin-node-resolve](https://github.com/rollup/plugins/tree/master/packages/node-resolve).
9393

94-
Some modules, like `events` or `util`, are built in to Node.js. If you want to include those (for example, so that your bundle runs in the browser), you may need to include [rollup-plugin-node-polyfills](https://github.com/ionic-team/rollup-plugin-node-polyfills).
94+
Some modules, like `events` or `util`, are built in to Node.js. If you want to include those (for example, so that your bundle runs in the browser), you may need to include [rollup-plugin-polyfill-node](https://github.com/snowpackjs/rollup-plugin-polyfill-node).
9595

9696
### Error: "EMFILE: too many open files"
9797

src/finalisers/shared/warnOnBuiltins.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ export default function warnOnBuiltins(
3838
code: 'MISSING_NODE_BUILTINS',
3939
message: `Creating a browser bundle that depends on Node.js built-in modules (${printQuotedStringList(
4040
externalBuiltins
41-
)}). You might need to include https://github.com/ionic-team/rollup-plugin-node-polyfills`,
41+
)}). You might need to include https://github.com/snowpackjs/rollup-plugin-polyfill-node`,
4242
modules: externalBuiltins
4343
});
4444
}

test/cli/samples/warn-multiple/_config.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ module.exports = {
77
assertIncludes(
88
stderr,
99
'(!) Missing shims for Node.js built-ins\n' +
10-
'Creating a browser bundle that depends on "url", "assert" and "path". You might need to include https://github.com/ionic-team/rollup-plugin-node-polyfills\n'
10+
'Creating a browser bundle that depends on "url", "assert" and "path". You might need to include https://github.com/snowpackjs/rollup-plugin-polyfill-node\n'
1111
);
1212
assertIncludes(
1313
stderr,

test/misc/misc.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ describe('misc', () => {
4949
assert.equal(relevantWarnings.length, 1);
5050
assert.equal(
5151
relevantWarnings[0].message,
52-
`Creating a browser bundle that depends on Node.js built-in modules ("util"). You might need to include https://github.com/ionic-team/rollup-plugin-node-polyfills`
52+
`Creating a browser bundle that depends on Node.js built-in modules ("util"). You might need to include https://github.com/snowpackjs/rollup-plugin-polyfill-node`
5353
);
5454
});
5555
});

0 commit comments

Comments
 (0)