Merge pull request Human-Connection#20 from Human-Connection/bugfix/email-case-sensitive

fix login email case sensitive bug

Author: visualjerk

server/authentication.js

@@ -1,6 +1,7 @@
 const authentication = require('feathers-authentication');
 const jwt = require('feathers-authentication-jwt');
 const local = require('feathers-authentication-local');
+const { lowerCase } = require('feathers-hooks-common');
 
 module.exports = function () {
   const app = this;
@@ -17,6 +18,7 @@ module.exports = function () {
   app.service('authentication').hooks({
     before: {
       create: [
+        lowerCase('email', 'username'),
         authentication.hooks.authenticate(config.strategies)
       ],
       remove: [

server/services/auth-management/auth-management.hooks.js

@@ -1,6 +1,6 @@
 const isEnabled = require('../../hooks/is-enabled');
 const { authenticate } = require('feathers-authentication').hooks;
-const commonHooks = require('feathers-hooks-common');
+const { iff } = require('feathers-hooks-common');
 
 const isAction = () => {
   let args = Array.from(arguments);
@@ -13,7 +13,7 @@ module.exports = {
     find: [],
     get: [],
     create: [
-      commonHooks.iff(
+      iff(
         isAction('passwordChange', 'identityChange'),
         [
           authenticate('jwt'),

server/services/users/users.hooks.js

@@ -109,6 +109,7 @@ module.exports = {
       ...restrict,
       hashPassword(),
       disableMultiItemChange(),
+      lowerCase('email', 'username'),
       when(isProvider('external'),
         restrictUserRole()
       ),
@@ -118,6 +119,7 @@ module.exports = {
       ...restrict,
       // hashPassword(),
       disableMultiItemChange(),
+      lowerCase('email', 'username'),
       // Only set slug once
       when(
         hook => {

test/services/authentication.js

@@ -0,0 +1,76 @@
+const assert = require('assert');
+const app = require('../../server/app');
+const service = app.service('authentication');
+const userService = app.service('users');
+
+describe('\'authentication\' service', () => {
+  before(function(done) {
+    this.server = app.listen(3031);
+    this.server.once('listening', () => done());
+  });
+
+  after(function(done) {
+    this.server.close(done);
+  });
+
+  beforeEach(async () => {
+    await app.get('mongooseClient').connection.dropDatabase();
+  });
+
+  afterEach(async () => {
+    await app.get('mongooseClient').connection.dropDatabase();
+  });
+
+  it('registered the service', () => {
+    assert.ok(service, 'Registered the service');
+  });
+
+  it('user can register', async () => {
+    const user = await userService.create({
+      email: '[email protected]',
+      password: '1234',
+      name: 'Peter',
+      role: 'admin'
+    });
+
+    assert.ok(user, 'user successfully registered');
+  });
+
+  it('user can login', async () => {
+    await userService.create({
+      email: '[email protected]',
+      password: '1234',
+      name: 'Peter',
+      role: 'admin'
+    });
+    const params = {
+      provider: 'socketio'
+    };
+    const { accessToken } = await service.create({
+      strategy: 'local',
+      email: '[email protected]',
+      password: '1234',
+    }, params);
+
+    assert.ok(accessToken, 'user successfully logged in');
+  });
+
+  it('ignores uppercase letters on login', async () => {
+    await userService.create({
+      email: '[email protected]',
+      password: '1234',
+      name: 'Peter',
+      role: 'admin'
+    });
+    const params = {
+      provider: 'socketio'
+    };
+    const { accessToken } = await service.create({
+      strategy: 'local',
+      email: '[email protected]',
+      password: '1234',
+    }, params);
+
+    assert.ok(accessToken, 'uppercase letters are ignored');
+  });
+});