Make sure NA attributes are rendered as blank for script (#201)

* Make sure NA attributes are rendered as blank for script

* test if defer = NA becomes defer attribute

* fix Error: Calling `brew cask install` is disabled! Use brew install [--cask] instead.

Author: atusy

.github/workflows/R-CMD-check.yaml

@@ -68,7 +68,7 @@ jobs:
       - name: Mac systemdeps
         if: runner.os == 'macOS'
         run: |
-          brew cask install xquartz
+          brew install --cask xquartz
           brew install cairo
 
       - name: Install dependencies

R/html_dependency.R

@@ -556,13 +556,11 @@ renderScript <- function(script, srcpath, encodeFunc, hrefFilter) {
     script, function(x) {
       x$src <- hrefFilter(file.path(srcpath, encodeFunc(x$src)))
       paste0(
-        "<script", 
+        "<script",
         paste0(
-         " ", 
+         " ",
          htmlEscape(names(x)),
-         '="', 
-         htmlEscape(x), 
-         '"', 
+         ifelse(is.na(x), "", paste0('="', htmlEscape(x), '"')),
          collapse = ''
         ),
       "></script>",

tests/testthat/test-deps.r

@@ -199,7 +199,8 @@ test_that("able to resolve HTML scripts supplied with & without integrity", {
       script = list(
         src = "p1.min.js",
         integrity = "longhash",
-        crossorigin = "anonymous"
+        crossorigin = "anonymous",
+        defer = NA
       )
     ),
     htmlDependency(
@@ -212,7 +213,7 @@ test_that("able to resolve HTML scripts supplied with & without integrity", {
   expect1 <- paste(
     '<script src="', src1, 'p1.min.js','" ',
     'integrity="longhash" ',
-    'crossorigin="anonymous"></script>',
+    'crossorigin="anonymous" defer></script>',
     sep = ''
   )
   expect2 <- paste(