Call out insecure PKCS #1 v1.5 default padding for RSA

bdewater · bdewater · commit fd5eaa6dfc9e · 2022-10-08T07:53:57.000-04:00
diff --git a/lib/openssl/pkey.rb b/lib/openssl/pkey.rb
@@ -363,7 +363,8 @@ def new(*args, &blk) # :nodoc:
     #    rsa.private_encrypt(string, padding) -> String
     #
     # Encrypt +string+ with the private key.  +padding+ defaults to
-    # PKCS1_PADDING. The encrypted string output can be decrypted using
+    # PKCS1_PADDING, which is known to be insecure but is kept for backwards
+    # compatibility. The encrypted string output can be decrypted using
     # #public_decrypt.
     #
     # <b>Deprecated in version 3.0</b>.
@@ -386,7 +387,8 @@ def private_encrypt(string, padding = PKCS1_PADDING)
     #    rsa.public_decrypt(string, padding) -> String
     #
     # Decrypt +string+, which has been encrypted with the private key, with the
-    # public key.  +padding+ defaults to PKCS1_PADDING.
+    # public key.  +padding+ defaults to PKCS1_PADDING which is known to be
+    # insecure but is kept for backwards compatibility.
     #
     # <b>Deprecated in version 3.0</b>.
     # Consider using PKey::PKey#sign_raw and PKey::PKey#verify_raw, and
@@ -407,7 +409,8 @@ def public_decrypt(string, padding = PKCS1_PADDING)
     #    rsa.public_encrypt(string, padding) -> String
     #
     # Encrypt +string+ with the public key.  +padding+ defaults to
-    # PKCS1_PADDING. The encrypted string output can be decrypted using
+    # PKCS1_PADDING, which is known to be insecure but is kept for backwards
+    # compatibility. The encrypted string output can be decrypted using
     # #private_decrypt.
     #
     # <b>Deprecated in version 3.0</b>.
@@ -428,7 +431,8 @@ def public_encrypt(data, padding = PKCS1_PADDING)
     #    rsa.private_decrypt(string, padding) -> String
     #
     # Decrypt +string+, which has been encrypted with the public key, with the
-    # private key. +padding+ defaults to PKCS1_PADDING.
+    # private key. +padding+ defaults to PKCS1_PADDING, which is known to be
+    # insecure but is kept for backwards compatibility.
     #
     # <b>Deprecated in version 3.0</b>.
     # Consider using PKey::PKey#encrypt and PKey::PKey#decrypt instead.

Original file line number	Diff line number	Diff line change
`@@ -363,7 +363,8 @@ def new(*args, &blk) # :nodoc:`
`363`	`363`	`# rsa.private_encrypt(string, padding) -> String`
`364`	`364`	`#`
`365`	`365`	`# Encrypt +string+ with the private key. +padding+ defaults to`
`366`		`- # PKCS1_PADDING. The encrypted string output can be decrypted using`
	`366`	`+ # PKCS1_PADDING, which is known to be insecure but is kept for backwards`
	`367`	`+ # compatibility. The encrypted string output can be decrypted using`
`367`	`368`	`# #public_decrypt.`
`368`	`369`	`#`
`369`	`370`	`# <b>Deprecated in version 3.0</b>.`
`@@ -386,7 +387,8 @@ def private_encrypt(string, padding = PKCS1_PADDING)`
`386`	`387`	`# rsa.public_decrypt(string, padding) -> String`
`387`	`388`	`#`
`388`	`389`	`# Decrypt +string+, which has been encrypted with the private key, with the`
`389`		`- # public key. +padding+ defaults to PKCS1_PADDING.`
	`390`	`+ # public key. +padding+ defaults to PKCS1_PADDING which is known to be`
	`391`	`+ # insecure but is kept for backwards compatibility.`
`390`	`392`	`#`
`391`	`393`	`# <b>Deprecated in version 3.0</b>.`
`392`	`394`	`# Consider using PKey::PKey#sign_raw and PKey::PKey#verify_raw, and`
`@@ -407,7 +409,8 @@ def public_decrypt(string, padding = PKCS1_PADDING)`
`407`	`409`	`# rsa.public_encrypt(string, padding) -> String`
`408`	`410`	`#`
`409`	`411`	`# Encrypt +string+ with the public key. +padding+ defaults to`
`410`		`- # PKCS1_PADDING. The encrypted string output can be decrypted using`
	`412`	`+ # PKCS1_PADDING, which is known to be insecure but is kept for backwards`
	`413`	`+ # compatibility. The encrypted string output can be decrypted using`
`411`	`414`	`# #private_decrypt.`
`412`	`415`	`#`
`413`	`416`	`# <b>Deprecated in version 3.0</b>.`
`@@ -428,7 +431,8 @@ def public_encrypt(data, padding = PKCS1_PADDING)`
`428`	`431`	`# rsa.private_decrypt(string, padding) -> String`
`429`	`432`	`#`
`430`	`433`	`# Decrypt +string+, which has been encrypted with the public key, with the`
`431`		`- # private key. +padding+ defaults to PKCS1_PADDING.`
	`434`	`+ # private key. +padding+ defaults to PKCS1_PADDING, which is known to be`
	`435`	`+ # insecure but is kept for backwards compatibility.`
`432`	`436`	`#`
`433`	`437`	`# <b>Deprecated in version 3.0</b>.`
`434`	`438`	`# Consider using PKey::PKey#encrypt and PKey::PKey#decrypt instead.`