Skip to content

Commit 23747b4

Browse files
committed
Support addition Object class when adding methods to top level
1 parent 1e16284 commit 23747b4

7 files changed

+21
-18
lines changed

Diff for: test/rdoc/test_rdoc_class_module.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ def test_add_comment_stopdoc
6363
end
6464

6565
def test_ancestors
66-
assert_equal [@parent, "Object"], @child.ancestors
66+
assert_equal [@parent, @object, "BasicObject"], @child.ancestors
6767
end
6868

6969
def test_comment_equals
@@ -129,7 +129,7 @@ def test_documented_eh
129129
end
130130

131131
def test_each_ancestor
132-
assert_equal [@parent], @child.each_ancestor.to_a
132+
assert_equal [@parent, @object], @child.each_ancestor.to_a
133133
end
134134

135135
def test_each_ancestor_cycle

Diff for: test/rdoc/test_rdoc_context.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ def test_add_class_basic_object
125125

126126
basic = @c1.find_module_named 'BasicObject'
127127

128-
assert_equal 'Object', basic.superclass
128+
assert_equal @object, basic.superclass
129129
end
130130

131131
def test_add_class_object

Diff for: test/rdoc/test_rdoc_extend.rb

+4-4
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ def test_module_extended
4343
m1_m2_k0.add_extend e0_m3
4444

4545
assert_equal [e0_m4, e0_m5, e0_m6, e0_m1, e0_m2, e0_m3], m1_m2_k0.extends
46-
assert_equal ['Object'], m1_m2_k0.ancestors
46+
assert_equal [@object, 'BasicObject'], m1_m2_k0.ancestors
4747

4848
m1_k1 = m1.add_class RDoc::NormalClass, 'Klass1'
4949

@@ -60,7 +60,7 @@ def test_module_extended
6060
m1_k1.add_extend e1_k0_m4
6161

6262
assert_equal [e1_m1, e1_m2, e1_m3, e1_m4, e1_k0_m4], m1_k1.extends
63-
assert_equal ['Object'], m1_k1.ancestors
63+
assert_equal [@object, 'BasicObject'], m1_k1.ancestors
6464

6565
m1_k2 = m1.add_class RDoc::NormalClass, 'Klass2'
6666

@@ -75,7 +75,7 @@ def test_module_extended
7575
m1_k2.add_extend e2_k0_m4
7676

7777
assert_equal [e2_m1, e2_m3, e2_m2, e2_k0_m4], m1_k2.extends
78-
assert_equal ['Object'], m1_k2.ancestors
78+
assert_equal [@object, 'BasicObject'], m1_k2.ancestors
7979

8080
m1_k3 = m1.add_class RDoc::NormalClass, 'Klass3'
8181

@@ -88,7 +88,7 @@ def test_module_extended
8888
m1_k3.add_extend e3_m4
8989

9090
assert_equal [e3_m1, e3_m2, e3_m4], m1_k3.extends
91-
assert_equal ['Object'], m1_k3.ancestors
91+
assert_equal [@object, 'BasicObject'], m1_k3.ancestors
9292
end
9393

9494
end

Diff for: test/rdoc/test_rdoc_include.rb

+6-5
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ def test_module_extended
4646

4747
assert_equal [i0_m4, i0_m5, i0_m6, i0_m1, i0_m2, i0_m3], m1_m2_k0.includes
4848
assert_equal [m1_m2_m3, m1_m2, m1, m1_m2_k0_m4_m6, m1_m2_k0_m5,
49-
m1_m2_k0_m4, 'Object'], m1_m2_k0.ancestors
49+
m1_m2_k0_m4, @object, 'BasicObject'], m1_m2_k0.ancestors
5050

5151
m1_k1 = m1.add_class RDoc::NormalClass, 'Klass1'
5252

@@ -63,8 +63,8 @@ def test_module_extended
6363
m1_k1.add_include i1_k0_m4
6464

6565
assert_equal [i1_m1, i1_m2, i1_m3, i1_m4, i1_k0_m4], m1_k1.includes
66-
assert_equal [m1_m2_k0_m4, m1_m2_m3_m4, m1_m2_m3, m1_m2, m1, 'Object'],
67-
m1_k1.ancestors
66+
assert_equal [m1_m2_k0_m4, m1_m2_m3_m4, m1_m2_m3, m1_m2, m1, @object,
67+
'BasicObject'], m1_k1.ancestors
6868

6969
m1_k2 = m1.add_class RDoc::NormalClass, 'Klass2'
7070

@@ -79,7 +79,8 @@ def test_module_extended
7979
m1_k2.add_include i2_k0_m4
8080

8181
assert_equal [i2_m1, i2_m3, i2_m2, i2_k0_m4], m1_k2.includes
82-
assert_equal [m1_m2_k0_m4, m1_m2, m1_m3, m1, 'Object'], m1_k2.ancestors
82+
assert_equal [m1_m2_k0_m4, m1_m2, m1_m3, m1, @object, 'BasicObject'],
83+
m1_k2.ancestors
8384

8485
m1_k3 = m1.add_class RDoc::NormalClass, 'Klass3'
8586

@@ -92,7 +93,7 @@ def test_module_extended
9293
m1_k3.add_include i3_m4
9394

9495
assert_equal [i3_m1, i3_m2, i3_m4], m1_k3.includes
95-
assert_equal [m1_m2_m4, m1_m2, m1, 'Object'], m1_k3.ancestors
96+
assert_equal [m1_m2_m4, m1_m2, m1, @object, 'BasicObject'], m1_k3.ancestors
9697
end
9798

9899
def test_store_equals

Diff for: test/rdoc/test_rdoc_normal_class.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,15 @@ def test_ancestors
1111
sub_klass.superclass = klass
1212
sub_klass.add_include incl
1313

14-
assert_equal [incl.name, klass, 'Object'], sub_klass.ancestors
14+
assert_equal [incl.name, klass, @object, 'BasicObject'], sub_klass.ancestors
1515
end
1616

1717
def test_ancestors_multilevel
1818
c1 = @top_level.add_class RDoc::NormalClass, 'Outer'
1919
c2 = @top_level.add_class RDoc::NormalClass, 'Middle', c1.full_name
2020
c3 = @top_level.add_class RDoc::NormalClass, 'Inner', c2.full_name
2121

22-
assert_equal [c2, c1, 'Object'], c3.ancestors
22+
assert_equal [c2, c1, @object, 'BasicObject'], c3.ancestors
2323
end
2424

2525
def test_aref

Diff for: test/rdoc/test_rdoc_store.rb

+4-2
Original file line numberDiff line numberDiff line change
@@ -161,9 +161,10 @@ def test_add_file_relative
161161

162162
def test_all_classes_and_modules
163163
expected = %w[
164-
C1 C2 C2::C3 C2::C3::H1 C3 C3::H1 C3::H2 C4 C4::C4 C5 C5::C1 C6 C7 C8 C8::S1 C9 C9::A C9::B
164+
C1 C10 C10::C11 C11 C2 C2::C3 C2::C3::H1 C3 C3::H1 C3::H2 C4 C4::C4 C5 C5::C1 C6 C7 C8 C8::S1 C9 C9::A C9::B
165165
Child
166166
M1 M1::M2
167+
Object
167168
Parent
168169
]
169170

@@ -212,8 +213,9 @@ def test_class_path
212213

213214
def test_classes
214215
expected = %w[
215-
C1 C2 C2::C3 C2::C3::H1 C3 C3::H1 C3::H2 C4 C4::C4 C5 C5::C1 C6 C7 C8 C8::S1 C9 C9::A C9::B
216+
C1 C10 C10::C11 C11 C2 C2::C3 C2::C3::H1 C3 C3::H1 C3::H2 C4 C4::C4 C5 C5::C1 C6 C7 C8 C8::S1 C9 C9::A C9::B
216217
Child
218+
Object
217219
Parent
218220
]
219221

Diff for: test/rdoc/test_rdoc_top_level.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ def test_add_method
9090
@top_level.add_method method
9191

9292
object = @store.find_class_named 'Object'
93-
assert_equal [method], object.method_list
93+
assert_equal [@c10_method, @c11_method, method], object.method_list
9494
assert_includes object.in_files, @top_level
9595
end
9696

@@ -101,7 +101,7 @@ def test_add_method_stopdoc
101101
@top_level.add_method method
102102

103103
object = @store.find_class_named('Object')
104-
assert_empty object.method_list
104+
assert_equal [@c10_method, @c11_method], object.method_list
105105
assert_includes object.in_files, @top_level
106106
end
107107

0 commit comments

Comments
 (0)