PR Feedback.

 * Rename QuoteLiteral -> quote_literal and move to after predicate_to_string.
 * Xpath -> XPath.
 * Replace %-substitution w/ String "#{...}".

Author: pulver

lib/rexml/parsers/xpathparser.rb

@@ -178,7 +178,7 @@ def predicate_to_string( path, &block )
         when :literal
           path.shift
           string << " "
-          string << QuoteLiteral(path.shift)
+          string << quote_literal(path.shift)
           string << " "
         else
           string << " "
@@ -188,6 +188,21 @@ def predicate_to_string( path, &block )
         return string.squeeze(" ")
       end
 
+      def quote_literal( literal )
+        case literal
+        when String
+          # XPath 1.0 does not support escape characters.
+          # Assumes literal does not contain both single and double quotes.
+          if literal.include?("'")
+            "\"#{literal}\""
+          else
+            "'#{literal}'"
+          end
+        else
+          literal.inspect
+        end
+      end
+
       private
       #LocationPath
       #  | RelativeLocationPath
@@ -363,18 +378,6 @@ def Predicate path, parsed
         path
       end
 
-      def QuoteLiteral literal
-        case literal
-        when String
-          # Xpath 1.0 does not support escape characters.
-          # Assumes literal does not contain both single and double quotes.
-          pattern = literal.include?('"') ? "'%s'" : '"%s"'
-          pattern % literal
-        else
-          literal.inspect
-        end
-      end
-
       # The following return arrays of true/false, a 1-1 mapping of the
       # supplied nodeset, except for axe(), which returns a filtered
       # nodeset