Skip to content

Commit 0b74597

Browse files
authored
fix: ignore .ssh pub keys (#109)
Signed-off-by: Justin Alvarez <[email protected]> Issue #, if available: Fixes #103. Still having trouble reproducing #38, but possibly related *Description of changes:* - Our Lima configuration (finch.yaml) was using the default value for the `ssh.loadDotSSHPubKeys` option, which is `true`. This may cause errors if the user has any issues with the keys in their `.ssh` directory. Since the correct key is generated and stored in Lima's directories, and the user is not expected to interact directly with the VM anyway, we can just set this to `false` explicitly - In the future, we can consider adding this to finch's config (probably by adding logic to `pkg/config`'s `lima_config_applier` and `defaults.go`) *Testing done:* - Reproduced the error by creating an invalid pub key entry. Made the change to my local `lima.yaml` and rebooted the vm, and did not see the error - [x] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: Justin Alvarez <[email protected]>
1 parent 934521c commit 0b74597

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Diff for: finch.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ ssh:
9292
# applications such as rsync with the Lima instance.
9393
# If you have an insecure key under ~/.ssh, do not use this option.
9494
# 🟢 Builtin default: true
95-
loadDotSSHPubKeys: null
95+
loadDotSSHPubKeys: false
9696
# Forward ssh agent into the instance.
9797
# 🟢 Builtin default: false
9898
forwardAgent: null

0 commit comments

Comments
 (0)