refactor: use logger formatter properly (#163)

## Summary

PR is a carry of #48.

## License Acceptance

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

---------

Signed-off-by: sivchari <[email protected]>
Signed-off-by: Hsing-Yu (David) Chen <[email protected]>
Co-authored-by: sivchari <[email protected]>

Author: davidhsingyuchen

cmd/finch/virtual_machine_init.go

@@ -78,7 +78,7 @@ func (iva *initVMAction) run() error {
 
 	err = dependency.InstallOptionalDeps(iva.optionalDepGroups, iva.logger)
 	if err != nil {
-		iva.logger.Error(fmt.Sprintf("Dependency error: %s", err))
+		iva.logger.Errorf("Dependency error: %v", err)
 	}
 
 	err = iva.limaConfigApplier.Apply()

cmd/finch/virtual_machine_init_test.go

@@ -254,7 +254,7 @@ func TestInitVMAction_run(t *testing.T) {
 				logger.EXPECT().Debugf("Status of virtual machine: %s", "")
 
 				lca.EXPECT().Apply().Return(errors.New("load config fails"))
-				logger.EXPECT().Error(fmt.Sprintf("Dependency error: failed to install dependencies: %v",
+				logger.EXPECT().Errorf("Dependency error: %v", fmt.Errorf("failed to install dependencies: %v",
 					[]error{fmt.Errorf("%s: %v", "mock_error_msg", []error{errors.New("dependency error occurs")})},
 				))
 			},

cmd/finch/virtual_machine_start.go

@@ -71,7 +71,7 @@ func (sva *startVMAction) run() error {
 	}
 	err = dependency.InstallOptionalDeps(sva.optionalDepGroups, sva.logger)
 	if err != nil {
-		sva.logger.Error(fmt.Sprintf("Dependency error: %s", err))
+		sva.logger.Errorf("Dependency error: %v", err)
 	}
 
 	err = sva.limaConfigApplier.Apply()

cmd/finch/virtual_machine_start_test.go

@@ -264,7 +264,7 @@ func TestStartVMAction_run(t *testing.T) {
 
 				lca.EXPECT().Apply().Return(errors.New("load config fails"))
 
-				logger.EXPECT().Error(fmt.Sprintf("Dependency error: failed to install dependencies: %v",
+				logger.EXPECT().Errorf("Dependency error: %v", fmt.Errorf("failed to install dependencies: %v",
 					[]error{fmt.Errorf("%s: %v", "mock_error_msg", []error{errors.New("dependency error occurs")})},
 				))
 			},

pkg/dependency/vmnet/binaries.go

@@ -70,7 +70,7 @@ func (bin *binaries) Installed() bool {
 		return false
 	}
 	if !dirExists {
-		bin.l.Infof("binaries directory doesn't exist")
+		bin.l.Info("binaries directory doesn't exist")
 		return false
 	}
 	buildArtifactFileBytes, err := afero.ReadFile(bin.fs, bin.buildArtifactSocketVmnetExe())

pkg/dependency/vmnet/binaries_test.go

@@ -87,7 +87,7 @@ func TestBinaries_Installed(t *testing.T) {
 				err := afero.WriteFile(mFs, "mock_prefix/dependencies/lima-socket-vmnet/opt/finch/bin/socket_vmnet", fileData, 0o666)
 				require.NoError(t, err)
 
-				l.EXPECT().Infof("binaries directory doesn't exist")
+				l.EXPECT().Info("binaries directory doesn't exist")
 			},
 			want: false,
 		},