Skip to content

Commit 5b0850f

Browse files
authored
test: increase vm init/start timeouts (#353)
Issue #, if available: *Description of changes:* - Been seeing a few test runs fail because of vm init timeouts. Trying to increase the timeout from 120 to 240 seconds to see if it helps. *Testing done:* - local testing - [x] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Signed-off-by: Justin Alvarez <[email protected]>
1 parent 39d1f17 commit 5b0850f

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

e2e/vm/config_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ func updateAndApplyConfig(o *option.Option, configBytes []byte) *gexec.Session {
4747
writeFile(finchConfigFilePath, configBytes)
4848

4949
command.New(o, virtualMachineRootCmd, "stop").WithoutCheckingExitCode().WithTimeoutInSeconds(90).Run()
50-
return command.New(o, virtualMachineRootCmd, "start").WithoutCheckingExitCode().WithTimeoutInSeconds(120).Run()
50+
return command.New(o, virtualMachineRootCmd, "start").WithoutCheckingExitCode().WithTimeoutInSeconds(240).Run()
5151
}
5252

5353
// testConfig updates the finch config file and ensures that its settings are applied properly.
@@ -83,7 +83,7 @@ var testConfig = func(o *option.Option, installed bool) {
8383
writeFile(limaConfigFilePath, origLimaCfg)
8484

8585
command.New(o, virtualMachineRootCmd, "stop").WithoutCheckingExitCode().WithTimeoutInSeconds(90).Run()
86-
command.New(o, virtualMachineRootCmd, "start").WithTimeoutInSeconds(600).Run()
86+
command.New(o, virtualMachineRootCmd, "start").WithTimeoutInSeconds(240).Run()
8787
})
8888
})
8989

@@ -199,7 +199,7 @@ additional_directories:
199199

200200
limaConfigFilePath := resetVM(o, installed)
201201
writeFile(finchConfigFilePath, []byte("memory: 4GiB\ncpus: 6\nvmType: vz\nrosetta: false"))
202-
initCmdSession := command.New(o, virtualMachineRootCmd, "init").WithTimeoutInSeconds(120).Run()
202+
initCmdSession := command.New(o, virtualMachineRootCmd, "init").WithTimeoutInSeconds(600).Run()
203203
gomega.Expect(initCmdSession).Should(gexec.Exit(0))
204204

205205
gomega.Expect(limaConfigFilePath).Should(gomega.BeARegularFile())

e2e/vm/lifecycle_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ var testVMLifecycle = func(o *option.Option) {
2727
command.Run(o, "images")
2828
command.New(o, virtualMachineRootCmd, "stop", "--force").WithTimeoutInSeconds(90).Run()
2929
command.RunWithoutSuccessfulExit(o, "images")
30-
command.New(o, virtualMachineRootCmd, "start").WithTimeoutInSeconds(120).Run()
30+
command.New(o, virtualMachineRootCmd, "start").WithTimeoutInSeconds(240).Run()
3131
})
3232

3333
ginkgo.It("should be able to force remove the virtual machine", func() {
@@ -55,7 +55,7 @@ var testVMLifecycle = func(o *option.Option) {
5555
})
5656

5757
ginkgo.It("should be able to start the virtual machine", func() {
58-
command.New(o, virtualMachineRootCmd, "start").WithTimeoutInSeconds(120).Run()
58+
command.New(o, virtualMachineRootCmd, "start").WithTimeoutInSeconds(240).Run()
5959
command.Run(o, "images")
6060
command.New(o, virtualMachineRootCmd, "stop").WithTimeoutInSeconds(90).Run()
6161
})

0 commit comments

Comments
 (0)