Skip to content

Commit e222131

Browse files
authored
fix(Makefile): use POSIX tar syntax for stdin (#529)
Issue #, if available: *Description of changes:* In x mode, all POSIX-compliant versions of tar require -f to read the input archive from somewhere other than the default. Some machines (e.g. Windows) may not have the GNU version of tar installed. *Testing done:* - [X] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: Gavin Inglis <[email protected]>
1 parent 21bb893 commit e222131

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

Makefile

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ finch-core:
6868
"$(MAKE)"
6969

7070
mkdir -p _output
71-
cd deps/finch-core/_output && tar c * | tar Cvx $(OUTDIR)
71+
cd deps/finch-core/_output && tar -cf - * | tar -xvf - -C $(OUTDIR)
7272
rm -rf $(OUTDIR)/lima-template
7373

7474
.PHONY: local-core
@@ -80,8 +80,8 @@ local-core:
8080
"$(MAKE)" lima lima-socket-vmnet
8181

8282
mkdir -p _output
83-
cd deps/finch-core/_output && tar c * | tar Cvx $(OUTDIR)
84-
cd deps/finch-core/src/lima/_output && tar c * | tar Cvx $(OUTDIR)/lima
83+
cd deps/finch-core/_output && tar -cf - * | tar -xvf - -C $(OUTDIR)
84+
cd deps/finch-core/src/lima/_output && tar -cf - * | tar -xvf - -C $(OUTDIR)/lima
8585
rm -rf $(OUTDIR)/lima-template
8686

8787
.PHONY: lima-and-qemu
@@ -121,7 +121,7 @@ config.yaml:
121121
.PHONY: copy
122122
copy:
123123
mkdir -p $(DEST)
124-
(cd _output && tar c * | tar Cvx $(DEST) )
124+
(cd _output && tar -cf - * | tar -xvf - -C $(DEST) )
125125

126126
.PHONY: install
127127
install: copy

0 commit comments

Comments
 (0)