Skip to content

Commit f140aa3

Browse files
authored
ci: move from manifest to config file (#746)
Issue #, if available: release-please action not triggering as expected, see [errors](https://github.com/runfinch/finch/actions/runs/7292396775/job/20104474662) and previous PR (#738) *Description of changes:* - I re-read the release-please-action [documentation](https://github.com/google-github-actions/release-please-action?tab=readme-ov-file#advanced-release-configuration), and I think I put the config in the wrong file in my previous PR. - Followed the instructions [here](https://github.com/googleapis/release-please/blob/main/docs/manifest-releaser.md) to create a manifest release since that seems to be what release-please requires when using a config file on v4 - Moved release-type to the config file instead of the yaml directly because the action [seems to branch](https://github.com/google-github-actions/release-please-action/blob/cc61a07e2da466bebbc19b3a7dd01d6aecb20d1e/src/index.ts#L83) its behavior depending on if that's present or not *Testing done:* - Tested on my fork, but its hard to replicate the upstream perfectly - [x] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Signed-off-by: Justin Alvarez <[email protected]>
1 parent 7d1e250 commit f140aa3

File tree

3 files changed

+60
-27
lines changed

3 files changed

+60
-27
lines changed

.github/workflows/release-please.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,3 @@ jobs:
99
runs-on: ubuntu-latest
1010
steps:
1111
- uses: google-github-actions/release-please-action@v4
12-
with:
13-
release-type: go

.release-please-manifest.json

Lines changed: 1 addition & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,3 @@
11
{
2-
".": {
3-
"package-name": "finch",
4-
"changelog-sections": [
5-
{
6-
"type": "feat",
7-
"section": "Features",
8-
"hidden": false
9-
},
10-
{
11-
"type": "fix",
12-
"section": "Bug Fixes",
13-
"hidden": false
14-
},
15-
{
16-
"type": "exp",
17-
"section": "Experimental",
18-
"hidden": false
19-
},
20-
{
21-
"type": "build",
22-
"section": "Build System or External Dependencies",
23-
"hidden": false
24-
}
25-
]
26-
}
2+
".": "1.0.1"
273
}

release-please-config.json

Lines changed: 59 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,59 @@
1+
{
2+
"$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json",
3+
"release-type": "go",
4+
"changelog-sections": [
5+
{
6+
"type": "build",
7+
"section": "Build System or External Dependencies",
8+
"hidden": false
9+
},
10+
{
11+
"type": "exp",
12+
"section": "Experimental",
13+
"hidden": false
14+
},
15+
{
16+
"type": "feat",
17+
"section": "Features",
18+
"hidden": false
19+
},
20+
{
21+
"type": "fix",
22+
"section": "Bug Fixes",
23+
"hidden": false
24+
},
25+
{
26+
"type": "revert",
27+
"section": "Reverts",
28+
"hidden": false
29+
},
30+
{
31+
"type": "chore",
32+
"section": "Miscellaneous Chores",
33+
"hidden": true
34+
},
35+
{
36+
"type": "docs",
37+
"section": "Documentation",
38+
"hidden": true
39+
},
40+
{
41+
"type": "refactor",
42+
"section": "Code Refactoring",
43+
"hidden": true
44+
},
45+
{
46+
"type": "test",
47+
"section": "Tests",
48+
"hidden": true
49+
},
50+
{
51+
"type": "ci",
52+
"section": "Continuous Integration",
53+
"hidden": true
54+
}
55+
],
56+
"packages": {
57+
".": {}
58+
}
59+
}

0 commit comments

Comments
 (0)