Skip to content

Commit 73d42ff

Browse files
bors[bot]couchand
andauthored
Merge #468
468: Improve documentation on generated registers and fields r=burrbull a=couchand Previously, the descriptions for fields were only listed on the docs for the accessor methods on the `R` and `W` structs. This adds the descriptions to the field accessor structs so they appear on the register module page, too. Co-authored-by: Andrew Dona-Couch <[email protected]>
2 parents 74e8004 + 667d2a1 commit 73d42ff

File tree

1 file changed

+10
-9
lines changed

1 file changed

+10
-9
lines changed

Diff for: src/generate/register.rs

+10-9
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ pub fn render(
5454
let can_reset = res_val.is_some();
5555

5656
if can_read {
57-
let desc = format!("Reader of register {}", register.name);
57+
let desc = format!("Register `{}` reader", register.name);
5858
mod_items.extend(quote! {
5959
#[doc = #desc]
6060
pub struct R(crate::R<#name_uc_spec>);
@@ -78,7 +78,7 @@ pub fn render(
7878
}
7979

8080
if can_write {
81-
let desc = format!("Writer for register {}", register.name);
81+
let desc = format!("Register `{}` writer", register.name);
8282
mod_items.extend(quote! {
8383
#[doc = #desc]
8484
pub struct W(crate::W<#name_uc_spec>);
@@ -350,12 +350,12 @@ pub fn fields(
350350
if can_read {
351351
let readerdoc = if let Some((_, _, _, _, suffixes_str)) = &field_dim {
352352
format!(
353-
"Reader of fields `{}`",
354-
util::replace_suffix(&f.name, suffixes_str)
353+
"Fields `{}` reader - {}",
354+
util::replace_suffix(&f.name, suffixes_str),
355+
description,
355356
)
356357
} else {
357-
let quotedfield = String::from("`") + &f.name + "`";
358-
String::from("Reader of field ") + &quotedfield
358+
format!("Field `{}` reader - {}", f.name, description)
359359
};
360360

361361
let name_pc_r = Ident::new(&(name_pc.clone() + "_R"), span);
@@ -687,12 +687,13 @@ pub fn fields(
687687
let offset_entry;
688688
if let Some((_, _, _, _, suffixes_str)) = &field_dim {
689689
doc = format!(
690-
"Write proxy for fields `{}`",
691-
util::replace_suffix(&f.name, suffixes_str)
690+
"Fields `{}` writer - {}",
691+
util::replace_suffix(&f.name, suffixes_str),
692+
description
692693
);
693694
offset_entry = quote! {offset: usize,};
694695
} else {
695-
doc = format!("Write proxy for field `{}`", f.name);
696+
doc = format!("Field `{}` writer - {}", f.name, description);
696697
offset_entry = quote! {};
697698
}
698699

0 commit comments

Comments
 (0)